Mirrors/ViaVersion
3
0
Fork 1
Mirror von https://github.com/ViaVersion/ViaVersion.git synchronisiert 2024-12-26 16:12:42 +01:00
Code Issues Releases Aktivität

Change 'quick-move-action-fix' to default disabled.

Quellcode durchsuchen 
This is until we can ensure no bugs happen with it if we're required to release.
See #780
Dieser Commit ist enthalten in:
Myles 2017-11-28 15:17:02 +00:00
Ursprung 12c21c9b0a
Commit 5a74e129a4
3 geänderte Dateien mit 6 neuen und 6 gelöschten Zeilen
Statistiken anzeigen Patch-Datei herunterladen Vergleichs-Datei herunterladen Alle Dateien ausklappen Alle Dateien einklappen

2
bukkit/src/main/java/us/myles/ViaVersion/bukkit/platform/BukkitConfigAPI.java
Datei anzeigen

@ -167,7 +167,7 @@ public class BukkitConfigAPI extends Config implements ViaVersionConfig {
@Override @Override
public boolean is1_12QuickMoveActionFix() { public boolean is1_12QuickMoveActionFix() {
return getBoolean("quick-move-action-fix", true); return getBoolean("quick-move-action-fix", false);
} }
@Override @Override

6
bukkit/src/main/java/us/myles/ViaVersion/bukkit/providers/BukkitInventoryQuickMoveProvider.java
Datei anzeigen

@ -44,6 +44,9 @@ public class BukkitInventoryQuickMoveProvider extends InventoryQuickMoveProvider
if (!supported) { if (!supported) {
return false; return false;
} }
if (slotId < 0) { // clicked out of inv slot
return false;
}
ProtocolInfo info = userConnection.get(ProtocolInfo.class); ProtocolInfo info = userConnection.get(ProtocolInfo.class);
UUID uuid = info.getUuid(); UUID uuid = info.getUuid();
BukkitInventoryUpdateTask updateTask = updateTasks.get(uuid); BukkitInventoryUpdateTask updateTask = updateTasks.get(uuid);
@ -66,9 +69,6 @@ public class BukkitInventoryQuickMoveProvider extends InventoryQuickMoveProvider
} }
InventoryView inv = p.getOpenInventory(); InventoryView inv = p.getOpenInventory();
short slotId = storage.getSlotId(); short slotId = storage.getSlotId();
if (slotId < 0) { // clicked out of inv slot
return null;
}
if (slotId > inv.countSlots()) { if (slotId > inv.countSlots()) {
return null; // wrong container open? return null; // wrong container open?
} }

4
common/src/main/resources/assets/viaversion/config.yml
Datei anzeigen

@ -84,8 +84,8 @@ hologram-y: -0.96
piston-animation-patch: false piston-animation-patch: false
# Should we fix nbt for 1.12 and above clients in chat messages (causes invalid item) # Should we fix nbt for 1.12 and above clients in chat messages (causes invalid item)
chat-nbt-fix: true chat-nbt-fix: true
# Should we fix shift quick move action for 1.12 clients (causes shift + double click not to work when moving items) (only works on 1.8-1.11.2 bukkit based servers) # Experimental - Should we fix shift quick move action for 1.12 clients (causes shift + double click not to work when moving items) (only works on 1.8-1.11.2 bukkit based servers)
quick-move-action-fix: true quick-move-action-fix: false
# #
#----------------------------------------------------------# #----------------------------------------------------------#
# 1.9 & 1.10 CLIENTS ON 1.8 SERVERS OPTIONS # # 1.9 & 1.10 CLIENTS ON 1.8 SERVERS OPTIONS #