Fix chunk sending order, Fixes #338, #292 (I believe.)

src/main/java/us/myles/ViaVersion/protocols/protocol1_9to1_8/packets/WorldPackets.java

@@ -115,14 +115,9 @@ public class WorldPackets {
                     @Override
                     public void handle(PacketWrapper wrapper) throws Exception {
                         ClientChunks clientChunks = wrapper.user().get(ClientChunks.class);
-                        Chunk chunk = wrapper.passthrough(new ChunkType(clientChunks));
+                        wrapper.passthrough(new ChunkType(clientChunks));
-                        if (chunk.isUnloadPacket()) {
+                        // eat any other data (Usually happens with unload packets)
-                            PacketWrapper unload = wrapper.create(0x1D);
+                        wrapper.read(Type.REMAINING_BYTES);
-                            unload.write(Type.INT, chunk.getX());
-                            unload.write(Type.INT, chunk.getZ());
-                            unload.send();
-                            wrapper.cancel();
-                        }
                     }
                 });
             }

src/main/java/us/myles/ViaVersion/protocols/protocol1_9to1_8/types/ChunkType.java

@@ -128,11 +128,15 @@ public class ChunkType extends PartialType<Chunk, ClientChunks> {
 
     @Override
     public void write(ByteBuf output, ClientChunks param, Chunk chunk) throws Exception {
-        if (chunk.isUnloadPacket()) return;
+        if (chunk.isUnloadPacket()) {
+            output.clear();
+            Type.VAR_INT.write(output, 0x1D); // Unload packet ID
+        }
 
         // Write primary info
         output.writeInt(chunk.getX());
         output.writeInt(chunk.getZ());
+        if (chunk.isUnloadPacket()) return;
         output.writeByte(chunk.isGroundUp() ? 0x01 : 0x00);
         Type.VAR_INT.write(output, chunk.getPrimaryBitmask());