From 46ca469a4ab9b3adf0da8e7aa4f7dbd58468697f Mon Sep 17 00:00:00 2001
From: kennytv <jahnke.nassim@gmail.com>
Date: Tue, 27 Jul 2021 11:58:24 +0200
Subject: [PATCH] Add author tag to constructed book nbt Fixes #2640

---
 .../protocol1_14to1_13_2/packets/WorldPackets.java        | 8 --------
 .../protocol1_17_1to1_17/Protocol1_17_1To1_17.java        | 3 +++
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_14to1_13_2/packets/WorldPackets.java b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_14to1_13_2/packets/WorldPackets.java
index 6d2eedc03..beb140bf7 100644
--- a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_14to1_13_2/packets/WorldPackets.java
+++ b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_14to1_13_2/packets/WorldPackets.java
@@ -263,14 +263,6 @@ public class WorldPackets {
                             }
                         }
                     }
-
-                    private Byte[] fromPrimitiveArray(byte[] bytes) {
-                        Byte[] newArray = new Byte[bytes.length];
-                        for (int i = 0; i < bytes.length; i++) {
-                            newArray[i] = bytes[i];
-                        }
-                        return newArray;
-                    }
                 });
             }
         });
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_17_1to1_17/Protocol1_17_1To1_17.java b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_17_1to1_17/Protocol1_17_1To1_17.java
index fd72dc221..411eb06a6 100644
--- a/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_17_1to1_17/Protocol1_17_1To1_17.java
+++ b/common/src/main/java/com/viaversion/viaversion/protocols/protocol1_17_1to1_17/Protocol1_17_1To1_17.java
@@ -109,6 +109,9 @@ public final class Protocol1_17_1To1_17 extends AbstractProtocol<ClientboundPack
                         String title = wrapper.read(TITLE_STRING_TYPE);
                         tag.put("title", new StringTag(title));
 
+                        // Even if unused, legacy servers check for the author tag
+                        tag.put("author", new StringTag(wrapper.user().getProtocolInfo().getUsername()));
+
                         // Write signing
                         wrapper.write(Type.BOOLEAN, true);
                     } else {