From 087bbdce1f9de4cee0c0a8618111c0752201f703 Mon Sep 17 00:00:00 2001 From: Nassim Jahnke Date: Sat, 30 Jul 2022 18:10:45 +0200 Subject: [PATCH] Fix 1.19+ sign opening on ~1.12 servers Fixes #3027 --- .../bukkit/providers/BukkitAckSequenceProvider.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bukkit/src/main/java/com/viaversion/viaversion/bukkit/providers/BukkitAckSequenceProvider.java b/bukkit/src/main/java/com/viaversion/viaversion/bukkit/providers/BukkitAckSequenceProvider.java index 5e3f4fc3b..18591b8c7 100644 --- a/bukkit/src/main/java/com/viaversion/viaversion/bukkit/providers/BukkitAckSequenceProvider.java +++ b/bukkit/src/main/java/com/viaversion/viaversion/bukkit/providers/BukkitAckSequenceProvider.java @@ -19,6 +19,7 @@ package com.viaversion.viaversion.bukkit.providers; import com.viaversion.viaversion.ViaVersionPlugin; import com.viaversion.viaversion.api.connection.UserConnection; +import com.viaversion.viaversion.api.protocol.version.ProtocolVersion; import com.viaversion.viaversion.bukkit.tasks.protocol1_19to1_18_2.AckSequenceTask; import com.viaversion.viaversion.protocols.protocol1_19to1_18_2.provider.AckSequenceProvider; import com.viaversion.viaversion.protocols.protocol1_19to1_18_2.storage.SequenceStorage; @@ -36,7 +37,9 @@ public final class BukkitAckSequenceProvider extends AckSequenceProvider { final SequenceStorage sequenceStorage = connection.get(SequenceStorage.class); final int previousSequence = sequenceStorage.setSequenceId(sequence); if (previousSequence == -1) { - plugin.getServer().getScheduler().scheduleSyncDelayedTask(plugin, new AckSequenceTask(connection, sequenceStorage), 1); + final int serverProtocolVersion = connection.getProtocolInfo().getServerProtocolVersion(); + final long delay = serverProtocolVersion > ProtocolVersion.v1_8.getVersion() && serverProtocolVersion < ProtocolVersion.v1_14.getVersion() ? 2 : 1; + plugin.getServer().getScheduler().scheduleSyncDelayedTask(plugin, new AckSequenceTask(connection, sequenceStorage), delay); } } } \ No newline at end of file