From 05aa05c5b4a030c93508586471182161f6aaaa69 Mon Sep 17 00:00:00 2001 From: Nassim Jahnke Date: Thu, 20 Jun 2024 15:31:18 +0200 Subject: [PATCH] Disable soul speed check for now --- .../listeners/v1_20_5to1_21/PlayerChangeItemListener.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bukkit/src/main/java/com/viaversion/viaversion/bukkit/listeners/v1_20_5to1_21/PlayerChangeItemListener.java b/bukkit/src/main/java/com/viaversion/viaversion/bukkit/listeners/v1_20_5to1_21/PlayerChangeItemListener.java index a4a84950f..82df84ff5 100644 --- a/bukkit/src/main/java/com/viaversion/viaversion/bukkit/listeners/v1_20_5to1_21/PlayerChangeItemListener.java +++ b/bukkit/src/main/java/com/viaversion/viaversion/bukkit/listeners/v1_20_5to1_21/PlayerChangeItemListener.java @@ -92,7 +92,9 @@ public final class PlayerChangeItemListener extends ViaBukkitListener { case LEGGINGS -> swiftSneakLevel = item != null && swiftSneak != null ? item.getEnchantmentLevel(swiftSneak) : 0; case BOOTS -> { depthStriderLevel = item != null && depthStrider != null ? item.getEnchantmentLevel(depthStrider) : 0; - soulSpeedLevel = item != null && soulSpeed != null ? item.getEnchantmentLevel(soulSpeed) : 0; + // TODO This needs continuous ticking for the supporting block as a conditional effect + // and is even more prone to desync from high ping than the other attributes + //soulSpeedLevel = item != null && soulSpeed != null ? item.getEnchantmentLevel(soulSpeed) : 0; } } storage.setEnchants(player.getEntityId(), connection, efficiencyLevel, soulSpeedLevel, swiftSneakLevel, depthStriderLevel);