From e662640377ce970e87f68cba097bb99c93ab0717 Mon Sep 17 00:00:00 2001 From: Nassim Jahnke Date: Mon, 17 Jun 2024 12:58:39 +0200 Subject: [PATCH] Handle item_name item data for component rewriting --- .../viabackwards/api/ViaBackwardsPlatform.java | 2 +- .../rewriters/BackwardsStructuredItemRewriter.java | 12 +++--------- settings.gradle.kts | 1 - 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/common/src/main/java/com/viaversion/viabackwards/api/ViaBackwardsPlatform.java b/common/src/main/java/com/viaversion/viabackwards/api/ViaBackwardsPlatform.java index 5cc10f7c..1ab0a7d7 100644 --- a/common/src/main/java/com/viaversion/viabackwards/api/ViaBackwardsPlatform.java +++ b/common/src/main/java/com/viaversion/viabackwards/api/ViaBackwardsPlatform.java @@ -69,7 +69,7 @@ import java.util.logging.Logger; public interface ViaBackwardsPlatform { - String MINIMUM_VV_VERSION = "5.0.0"; + String MINIMUM_VV_VERSION = "5.0.1"; /** * Initialize ViaBackwards. diff --git a/common/src/main/java/com/viaversion/viabackwards/api/rewriters/BackwardsStructuredItemRewriter.java b/common/src/main/java/com/viaversion/viabackwards/api/rewriters/BackwardsStructuredItemRewriter.java index b941ce31..ac654a9c 100644 --- a/common/src/main/java/com/viaversion/viabackwards/api/rewriters/BackwardsStructuredItemRewriter.java +++ b/common/src/main/java/com/viaversion/viabackwards/api/rewriters/BackwardsStructuredItemRewriter.java @@ -67,14 +67,8 @@ public class BackwardsStructuredItemRewriter customNameData = dataContainer.getNonEmpty(StructuredDataKey.CUSTOM_NAME); - if (customNameData != null) { - final Tag originalName = customNameData.value().copy(); - protocol.getComponentRewriter().processTag(connection, customNameData.value()); - if (!customNameData.value().equals(originalName)) { - saveTag(createCustomTag(item), originalName, "Name"); - } - } + updateComponent(connection, item, StructuredDataKey.ITEM_NAME, "item_name"); + updateComponent(connection, item, StructuredDataKey.CUSTOM_NAME, "custom_name"); final StructuredData loreData = dataContainer.getNonEmpty(StructuredDataKey.LORE); if (loreData != null) { @@ -115,7 +109,7 @@ public class BackwardsStructuredItemRewriter