From bdc79c43eb11440e498cdff447a622dca2c7b8e9 Mon Sep 17 00:00:00 2001
From: KennyTV <kennytv@t-online.de>
Date: Fri, 19 Jun 2020 17:47:43 +0200
Subject: [PATCH] Remove unmapped piston warning Remove some wont-fix/unneeded
 todos

---
 .../protocol1_10to1_11/packets/BlockItemPackets1_11.java       | 2 +-
 .../protocol1_11_1to1_12/packets/BlockItemPackets1_12.java     | 2 +-
 .../protocol/protocol1_12_2to1_13/Protocol1_12_2To1_13.java    | 2 +-
 .../block_entity_handlers/PistonHandler.java                   | 3 +--
 .../protocol1_12_2to1_13/packets/PlayerPacket1_13.java         | 2 +-
 .../protocol1_13_2to1_14/packets/EntityPackets1_14.java        | 1 -
 6 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_10to1_11/packets/BlockItemPackets1_11.java b/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_10to1_11/packets/BlockItemPackets1_11.java
index bcd0426d..3a4373b4 100644
--- a/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_10to1_11/packets/BlockItemPackets1_11.java
+++ b/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_10to1_11/packets/BlockItemPackets1_11.java
@@ -192,7 +192,7 @@ public class BlockItemPackets1_11 extends LegacyBlockItemRewriter<Protocol1_10To
 
                         handleChunk(chunk);
 
-                        // only patch it for signs for now, TODO-> Find all the block entities old/new to replace ids and implement in ViaVersion
+                        // only patch it for signs for now
                         for (CompoundTag tag : chunk.getBlockEntities()) {
                             Tag idTag = tag.get("id");
                             if (!(idTag instanceof StringTag)) continue;
diff --git a/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_11_1to1_12/packets/BlockItemPackets1_12.java b/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_11_1to1_12/packets/BlockItemPackets1_12.java
index a751c328..3db9c1bd 100644
--- a/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_11_1to1_12/packets/BlockItemPackets1_12.java
+++ b/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_11_1to1_12/packets/BlockItemPackets1_12.java
@@ -239,7 +239,7 @@ public class BlockItemPackets1_12 extends LegacyBlockItemRewriter<Protocol1_11_1
                     public void handle(PacketWrapper wrapper) throws Exception {
                         // Open Inventory
                         if (wrapper.get(Type.VAR_INT, 0) == 2) {
-                            wrapper.cancel(); // TODO is this replaced by something else?
+                            wrapper.cancel();
                         }
                     }
                 });
diff --git a/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/Protocol1_12_2To1_13.java b/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/Protocol1_12_2To1_13.java
index 041f03fd..b47fae02 100644
--- a/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/Protocol1_12_2To1_13.java
+++ b/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/Protocol1_12_2To1_13.java
@@ -78,7 +78,7 @@ public class Protocol1_12_2To1_13 extends BackwardsProtocol<ClientboundPackets1_
         cancelOutgoing(ClientboundPackets1_13.CRAFT_RECIPE_RESPONSE);
         cancelOutgoing(ClientboundPackets1_13.UNLOCK_RECIPES);
         cancelOutgoing(ClientboundPackets1_13.ADVANCEMENTS);
-        cancelOutgoing(ClientboundPackets1_13.DECLARE_RECIPES); //TODO ?
+        cancelOutgoing(ClientboundPackets1_13.DECLARE_RECIPES);
         cancelOutgoing(ClientboundPackets1_13.TAGS);
 
         cancelIncoming(ServerboundPackets1_12_1.CRAFT_RECIPE_REQUEST);
diff --git a/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/block_entity_handlers/PistonHandler.java b/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/block_entity_handlers/PistonHandler.java
index c313b541..fb2d016e 100644
--- a/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/block_entity_handlers/PistonHandler.java
+++ b/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/block_entity_handlers/PistonHandler.java
@@ -1,6 +1,5 @@
 package nl.matsv.viabackwards.protocol.protocol1_12_2to1_13.block_entity_handlers;
 
-import nl.matsv.viabackwards.ViaBackwards;
 import nl.matsv.viabackwards.protocol.protocol1_12_2to1_13.data.BackwardsMappings;
 import nl.matsv.viabackwards.protocol.protocol1_12_2to1_13.providers.BackwardsBlockEntityProvider;
 import us.myles.ViaVersion.api.Via;
@@ -74,7 +73,7 @@ public class PistonHandler implements BackwardsBlockEntityProvider.BackwardsBloc
 
         Integer id = pistonIds.get(dataFromTag);
         if (id == null) {
-            ViaBackwards.getPlatform().getLogger().warning("Unmapped piston id: " + dataFromTag);
+            //TODO see why this could be null and if this is bad
             return tag;
         }
 
diff --git a/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/packets/PlayerPacket1_13.java b/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/packets/PlayerPacket1_13.java
index 970c576b..8f440557 100644
--- a/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/packets/PlayerPacket1_13.java
+++ b/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/packets/PlayerPacket1_13.java
@@ -513,7 +513,7 @@ public class PlayerPacket1_13 extends Rewriter<Protocol1_12_2To1_13> {
                             int statisticId = wrapper.read(Type.VAR_INT);
 
                             String name = "";
-                            //TODO categories 0-7 (items, blocks, entities) - probably not feasible
+                            // categories 0-7 (items, blocks, entities) - probably not feasible
                             switch (categoryId) {
                                 case 0:
                                 case 1:
diff --git a/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_13_2to1_14/packets/EntityPackets1_14.java b/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_13_2to1_14/packets/EntityPackets1_14.java
index d5386f2b..a3644b6e 100644
--- a/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_13_2to1_14/packets/EntityPackets1_14.java
+++ b/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_13_2to1_14/packets/EntityPackets1_14.java
@@ -381,7 +381,6 @@ public class EntityPackets1_14 extends LegacyEntityRewriter<Protocol1_13_2To1_14
             if (type.isOrHasParent(Entity1_14Types.EntityType.ABSTRACT_ILLAGER_BASE) || type == Entity1_14Types.EntityType.RAVAGER || type == Entity1_14Types.EntityType.WITCH) {
                 int index = e.getIndex();
                 if (index == 14) {
-                    //TODO handle
                     throw RemovedValueException.EX;
                 } else if (index > 14) {
                     meta.setId(index - 1);