Merge branch 'master' into dev

core/src/main/java/nl/matsv/viabackwards/api/rewriters/BlockItemRewriter.java

@@ -138,10 +138,18 @@ public abstract class BlockItemRewriter<T extends BackwardsProtocol> extends Rew
             if (!(tag.contains("x") && tag.contains("y") && tag.contains("z")))
                 continue;
             Pos pos = new Pos(
-                    (int) tag.get("x").getValue() % 16,
+                    (int) tag.get("x").getValue() & 0xF,
                     (int) tag.get("y").getValue(),
-                    (int) tag.get("z").getValue() % 16);
+                    (int) tag.get("z").getValue() & 0xF);
             tags.put(pos, tag);
+
+            // Handle given Block Entities
+            ChunkSection section = chunk.getSections()[pos.getY() >> 4];
+            if (section == null) continue;
+            int block = section.getFlatBlock(pos.getX(), pos.getY() & 0xF, pos.getZ());
+            int btype = block >> 4;
+            if (!hasBlockEntityHandler(btype)) continue;
+            replacementData.get(btype).getBlockEntityHandler().handleOrNewCompoundTag(block, tag);
         }
 
         for (int i = 0; i < chunk.getSections().length; i++) {
@@ -149,32 +157,45 @@ public abstract class BlockItemRewriter<T extends BackwardsProtocol> extends Rew
             if (section == null)
                 continue;
 
+            boolean hasBlockEntityHandler = false;
+
+            // Map blocks
+            for (int j = 0; j < section.getPaletteSize(); j++) {
+                int block = section.getPaletteEntry(j);
+                int btype = block >> 4;
+                int meta = block & 0xF;
+
+                if (containsBlock(btype)) {
+                    Block b = handleBlock(btype, meta);
+                    section.setPaletteEntry(j, (b.getId() << 4) | (b.getData() & 0xF));
+                }
+
+                hasBlockEntityHandler = hasBlockEntityHandler || hasBlockEntityHandler(btype);
+            }
+
+            if (!hasBlockEntityHandler) continue;
+
+            // We need to handle a Block Entity :(
             for (int x = 0; x < 16; x++) {
                 for (int y = 0; y < 16; y++) {
                     for (int z = 0; z < 16; z++) {
-                        int block = section.getBlock(x, y, z);
+                        int block = section.getFlatBlock(x, y, z);
                         int btype = block >> 4;
                         int meta = block & 15;
 
-                        if (containsBlock(btype)) {
+                        if (!hasBlockEntityHandler(btype)) continue;
-                            Block b = handleBlock(btype, meta); // Type / data
+
-                            section.setBlock(x, y, z, b.getId(), b.getData());
+                        Pos pos = new Pos(x, (y + (i << 4)), z);
-                        }
+
-                        // Entity Tags
+                        // Already handled above
-                        if (hasBlockEntityHandler(btype)) {
+                        if (tags.containsKey(pos)) continue;
-                            Pos pos = new Pos(x, (y + (i << 4)), z);
+
-                            CompoundTag tag = null;
+                        CompoundTag tag = new CompoundTag("");
-                            if (tags.containsKey(pos)) {
+                        tag.put(new IntTag("x", x + (chunk.getX() << 4)));
-                                tag = tags.get(pos);
+                        tag.put(new IntTag("y", y + (i << 4)));
-                            } else {
+                        tag.put(new IntTag("z", z + (chunk.getZ() << 4)));
-                                tag = new CompoundTag("");
+                        replacementData.get(btype).getBlockEntityHandler().handleOrNewCompoundTag(block, tag);
-                                tag.put(new IntTag("x", x + (chunk.getX() << 4)));
+                        chunk.getBlockEntities().add(tag);
-                                tag.put(new IntTag("y", y + (i << 4)));
-                                tag.put(new IntTag("z", z + (chunk.getZ() << 4)));
-                                chunk.getBlockEntities().add(tag);
-                            }
-                            replacementData.get(btype).getBlockEntityHandler().handleOrNewCompoundTag(block, tag);
-                        }
                     }
                 }
             }

core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_10to1_11/packets/BlockItemPackets1_11.java

@@ -22,13 +22,13 @@ import nl.matsv.viabackwards.protocol.protocol1_12to1_11_1.data.BlockColors;
 import nl.matsv.viabackwards.utils.Block;
 import us.myles.ViaVersion.api.PacketWrapper;
 import us.myles.ViaVersion.api.data.UserConnection;
+import us.myles.ViaVersion.api.minecraft.chunks.Chunk;
 import us.myles.ViaVersion.api.minecraft.item.Item;
 import us.myles.ViaVersion.api.minecraft.metadata.Metadata;
 import us.myles.ViaVersion.api.remapper.PacketHandler;
 import us.myles.ViaVersion.api.remapper.PacketRemapper;
 import us.myles.ViaVersion.api.type.Type;
 import us.myles.ViaVersion.packets.State;
-import us.myles.ViaVersion.protocols.protocol1_9_1_2to1_9_3_4.chunks.Chunk1_9_3_4;
 import us.myles.ViaVersion.protocols.protocol1_9_1_2to1_9_3_4.types.Chunk1_9_3_4Type;
 import us.myles.ViaVersion.protocols.protocol1_9_3to1_9_1_2.storage.ClientWorld;
 import us.myles.viaversion.libs.opennbt.tag.builtin.CompoundTag;
@@ -226,7 +226,7 @@ public class BlockItemPackets1_11 extends BlockItemRewriter<Protocol1_10To1_11>
                                 ClientWorld clientWorld = wrapper.user().get(ClientWorld.class);
 
                                 Chunk1_9_3_4Type type = new Chunk1_9_3_4Type(clientWorld); // Use the 1.10 Chunk type since nothing changed.
-                                Chunk1_9_3_4 chunk = (Chunk1_9_3_4) wrapper.passthrough(type);
+                                Chunk chunk = wrapper.passthrough(type);
 
                                 handleChunk(chunk);
 

core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/packets/BlockItemPackets1_13.java

@@ -47,10 +47,10 @@ public class BlockItemPackets1_13 extends BlockItemRewriter<Protocol1_12_2To1_13
                                         continue;
                                     }
 
-                                    for (int p = 0; p < section.getPalette().size(); p++) {
+                                    for (int p = 0; p < section.getPaletteSize(); p++) {
-                                        int old = section.getPalette().get(p);
+                                        int old = section.getPaletteEntry(p);
                                         if (old != 0) {
-                                            section.getPalette().set(p, toNewId(old));
+                                            section.setPaletteEntry(p, toNewId(old));
                                         }
                                     }
                                 }

core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12to1_11_1/packets/BlockItemPackets1_12.java

@@ -16,13 +16,13 @@ import nl.matsv.viabackwards.protocol.protocol1_12to1_11_1.data.BlockColors;
 import nl.matsv.viabackwards.protocol.protocol1_12to1_11_1.data.MapColorMapping;
 import nl.matsv.viabackwards.utils.Block;
 import us.myles.ViaVersion.api.PacketWrapper;
+import us.myles.ViaVersion.api.minecraft.chunks.Chunk;
 import us.myles.ViaVersion.api.minecraft.item.Item;
 import us.myles.ViaVersion.api.minecraft.metadata.Metadata;
 import us.myles.ViaVersion.api.remapper.PacketHandler;
 import us.myles.ViaVersion.api.remapper.PacketRemapper;
 import us.myles.ViaVersion.api.type.Type;
 import us.myles.ViaVersion.packets.State;
-import us.myles.ViaVersion.protocols.protocol1_9_1_2to1_9_3_4.chunks.Chunk1_9_3_4;
 import us.myles.ViaVersion.protocols.protocol1_9_1_2to1_9_3_4.types.Chunk1_9_3_4Type;
 import us.myles.ViaVersion.protocols.protocol1_9_3to1_9_1_2.storage.ClientWorld;
 import us.myles.viaversion.libs.opennbt.tag.builtin.CompoundTag;
@@ -209,7 +209,7 @@ public class BlockItemPackets1_12 extends BlockItemRewriter<Protocol1_11_1To1_12
                                 ClientWorld clientWorld = wrapper.user().get(ClientWorld.class);
 
                                 Chunk1_9_3_4Type type = new Chunk1_9_3_4Type(clientWorld); // Use the 1.9.4 Chunk type since nothing changed.
-                                Chunk1_9_3_4 chunk = (Chunk1_9_3_4) wrapper.passthrough(type);
+                                Chunk chunk = wrapper.passthrough(type);
 
                                 handleChunk(chunk);
                             }

core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_13to1_13_1/packets/WorldPackets.java

@@ -28,10 +28,10 @@ public class WorldPackets {
 
                         for (ChunkSection section : chunk.getSections()) {
                             if (section != null) {
-                                for (int i = 0; i < section.getPalette().size(); i++) {
+                                for (int i = 0; i < section.getPaletteSize(); i++) {
-                                    section.getPalette().set(
+                                    section.setPaletteEntry(
                                             i,
-                                            Protocol1_13To1_13_1.getNewBlockStateId(section.getPalette().get(i))
+                                            Protocol1_13To1_13_1.getNewBlockStateId(section.getPaletteEntry(i))
                                     );
                                 }
                             }

core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_9_4to1_10/packets/BlockItemPackets1_10.java

@@ -14,13 +14,13 @@ import nl.matsv.viabackwards.api.rewriters.BlockItemRewriter;
 import nl.matsv.viabackwards.protocol.protocol1_9_4to1_10.Protocol1_9_4To1_10;
 import nl.matsv.viabackwards.utils.Block;
 import us.myles.ViaVersion.api.PacketWrapper;
+import us.myles.ViaVersion.api.minecraft.chunks.Chunk;
 import us.myles.ViaVersion.api.minecraft.item.Item;
 import us.myles.ViaVersion.api.minecraft.metadata.Metadata;
 import us.myles.ViaVersion.api.remapper.PacketHandler;
 import us.myles.ViaVersion.api.remapper.PacketRemapper;
 import us.myles.ViaVersion.api.type.Type;
 import us.myles.ViaVersion.packets.State;
-import us.myles.ViaVersion.protocols.protocol1_9_1_2to1_9_3_4.chunks.Chunk1_9_3_4;
 import us.myles.ViaVersion.protocols.protocol1_9_1_2to1_9_3_4.types.Chunk1_9_3_4Type;
 import us.myles.ViaVersion.protocols.protocol1_9_3to1_9_1_2.storage.ClientWorld;
 
@@ -166,7 +166,7 @@ public class BlockItemPackets1_10 extends BlockItemRewriter<Protocol1_9_4To1_10>
                                 ClientWorld clientWorld = wrapper.user().get(ClientWorld.class);
 
                                 Chunk1_9_3_4Type type = new Chunk1_9_3_4Type(clientWorld);
-                                Chunk1_9_3_4 chunk = (Chunk1_9_3_4) wrapper.passthrough(type);
+                                Chunk chunk = wrapper.passthrough(type);
 
                                 handleChunk(chunk);
                             }

pom.xml

@@ -65,7 +65,7 @@
         <dependency>
             <groupId>us.myles</groupId>
             <artifactId>viaversion</artifactId>
-            <version>1.6.0</version>
+            <version>2.0.0-SNAPSHOT</version>
             <scope>provided</scope>
         </dependency>
     </dependencies>