3
0
Mirror von https://github.com/ViaVersion/ViaBackwards.git synchronisiert 2024-12-25 15:50:12 +01:00

[ci skip] Update some text and comments

Dieser Commit ist enthalten in:
Nassim Jahnke 2024-12-15 10:05:53 +01:00
Ursprung 563a3e518d
Commit 3896a12166
Es konnte kein GPG-Schlüssel zu dieser Signatur gefunden werden
GPG-Schlüssel-ID: EF6771C01F6EF02F
2 geänderte Dateien mit 9 neuen und 6 gelöschten Zeilen

Datei anzeigen

@ -19,10 +19,11 @@ body:
- type: textarea
attributes:
label: Console Error
label: Server/Client Error
description: |
If you encounter warnings/errors in your console, **paste them with https://mclo.gs/ and put the paste link here**.
If the error is small/less than 10 lines, you may put it directly into this field.
**Important**: If you are kicked for `Network Protocol Error` or an encoder/decoder exception, please click the `Open Report Directory` button on your client and paste the newest disconnect file contents.
value: |
```
Put the mclo.gs link or text here.
@ -38,7 +39,7 @@ body:
Describe the unexpected behavior.
If you want to attach screenshots, use the comment field at the bottom of the page.
placeholder: |
Example: "Placing signs on 1.13.2 causes text to disappear."
Example: "Placing signs on 1.16.5 causes text to disappear."
validations:
required: true
@ -49,7 +50,7 @@ body:
List the steps on how we can reproduce the issue. Make sure we can easily understand what you mean with each step.
placeholder: |
Example:
1. Login with a 1.13.2 client
1. Login with a 1.16.5 client
2. Place a sign
3. The sign text is displayed wrong
validations:

Datei anzeigen

@ -367,12 +367,14 @@ public class PlayerPacketRewriter1_13 extends RewriterBase<Protocol1_13To1_12_2>
case "MC|AdvCmd" -> {
byte type = wrapper.read(Types.BYTE);
if (type == 0) {
//Information from https://wiki.vg/index.php?title=Plugin_channels&oldid=14089
//The Notchain client only uses this for command block minecarts and uses MC|AutoCmd for blocks, but the Notchian server still accepts it for either.
//Information from https://wiki.vg/index.php?title=Plugin_channels&oldid=14089 (see web archive)
//The Vanilla client only uses this for command block minecarts and uses MC|AutoCmd for blocks, but the server still accepts it for either.
//Maybe older versions used this and we need to implement this? The issue is that we would have to save the command block types
wrapper.setPacketType(ServerboundPackets1_13.SET_COMMAND_BLOCK);
wrapper.cancel();
protocol.getLogger().warning("Client send MC|AdvCmd custom payload to update command block, weird!");
if (!Via.getConfig().isSuppressConversionWarnings()) {
protocol.getLogger().warning("Client send MC|AdvCmd custom payload to update command block, weird!");
}
} else if (type == 1) {
wrapper.setPacketType(ServerboundPackets1_13.SET_COMMAND_MINECART);
wrapper.write(Types.VAR_INT, wrapper.read(Types.INT)); //Entity Id