Mirrors/Velocity
3
0
Fork 1
Mirror von https://github.com/PaperMC/Velocity.git synchronisiert 2024-12-26 00:00:55 +01:00
Code Issues Pakete Projekte Releases Wiki Aktivität

We don't need to retain/release the mod list buffer in readModList

Quellcode durchsuchen
Dieser Commit ist enthalten in:
Andrew Steinborn 2020-11-05 20:04:31 -05:00
Ursprung 91b295ead5
Commit cc89a2a1e5
1 geänderte Dateien mit 13 neuen und 19 gelöschten Zeilen
Statistiken anzeigen Patch-Datei herunterladen Vergleichs-Datei herunterladen Alle Dateien ausklappen Alle Dateien einklappen

18
proxy/src/main/java/com/velocitypowered/proxy/connection/forge/legacy/LegacyForgeUtil.java
Datei anzeigen

@ -39,21 +39,18 @@ class LegacyForgeUtil {
*/ */
static List<ModInfo.Mod> readModList(PluginMessage message) { static List<ModInfo.Mod> readModList(PluginMessage message) {
Preconditions.checkNotNull(message, "message"); Preconditions.checkNotNull(message, "message");
Preconditions Preconditions.checkArgument(message.getChannel().equals(FORGE_LEGACY_HANDSHAKE_CHANNEL),
.checkArgument(message.getChannel().equals(FORGE_LEGACY_HANDSHAKE_CHANNEL),
"message is not a FML HS plugin message"); "message is not a FML HS plugin message");
ByteBuf byteBuf = message.content().retainedSlice(); ByteBuf contents = message.content().slice();
try { byte discriminator = contents.readByte();
byte discriminator = byteBuf.readByte();
if (discriminator == MOD_LIST_DISCRIMINATOR) { if (discriminator == MOD_LIST_DISCRIMINATOR) {
ImmutableList.Builder<ModInfo.Mod> mods = ImmutableList.builder(); ImmutableList.Builder<ModInfo.Mod> mods = ImmutableList.builder();
int modCount = ProtocolUtils.readVarInt(byteBuf); int modCount = ProtocolUtils.readVarInt(contents);
for (int index = 0; index < modCount; index++) { for (int index = 0; index < modCount; index++) {
String id = ProtocolUtils.readString(byteBuf); String id = ProtocolUtils.readString(contents);
String version = ProtocolUtils.readString(byteBuf); String version = ProtocolUtils.readString(contents);
mods.add(new ModInfo.Mod(id, version)); mods.add(new ModInfo.Mod(id, version));
} }
@ -61,9 +58,6 @@ class LegacyForgeUtil {
} }
return ImmutableList.of(); return ImmutableList.of();
} finally {
byteBuf.release();
}
} }
/** /**