From 9c9fa1c5ae2979b72ef7cbc621b3025434084167 Mon Sep 17 00:00:00 2001 From: Andrew Steinborn Date: Mon, 9 Sep 2019 00:47:42 -0400 Subject: [PATCH] Remove flush consolidation for now This is still highly experimental --- .../proxy/connection/backend/VelocityServerConnection.java | 3 --- .../proxy/network/ServerChannelInitializer.java | 5 ----- 2 files changed, 8 deletions(-) diff --git a/proxy/src/main/java/com/velocitypowered/proxy/connection/backend/VelocityServerConnection.java b/proxy/src/main/java/com/velocitypowered/proxy/connection/backend/VelocityServerConnection.java index 6dc1868cc..da9806e16 100644 --- a/proxy/src/main/java/com/velocitypowered/proxy/connection/backend/VelocityServerConnection.java +++ b/proxy/src/main/java/com/velocitypowered/proxy/connection/backend/VelocityServerConnection.java @@ -39,7 +39,6 @@ import io.netty.channel.Channel; import io.netty.channel.ChannelFutureListener; import io.netty.channel.ChannelInitializer; import io.netty.handler.flow.FlowControlHandler; -import io.netty.handler.flush.FlushConsolidationHandler; import io.netty.handler.timeout.ReadTimeoutHandler; import java.util.concurrent.CompletableFuture; import java.util.concurrent.TimeUnit; @@ -84,8 +83,6 @@ public class VelocityServerConnection implements MinecraftConnectionAssociation, @Override protected void initChannel(Channel ch) throws Exception { ch.pipeline() - .addLast(FLUSH_CONSOLIDATION, new FlushConsolidationHandler( - FLUSH_CONSOLIDATION_AMOUNT, true)) .addLast(READ_TIMEOUT, new ReadTimeoutHandler(server.getConfiguration().getReadTimeout(), TimeUnit.MILLISECONDS)) diff --git a/proxy/src/main/java/com/velocitypowered/proxy/network/ServerChannelInitializer.java b/proxy/src/main/java/com/velocitypowered/proxy/network/ServerChannelInitializer.java index 4ed9a8e39..64d2ec835 100644 --- a/proxy/src/main/java/com/velocitypowered/proxy/network/ServerChannelInitializer.java +++ b/proxy/src/main/java/com/velocitypowered/proxy/network/ServerChannelInitializer.java @@ -1,7 +1,5 @@ package com.velocitypowered.proxy.network; -import static com.velocitypowered.proxy.network.Connections.FLUSH_CONSOLIDATION; -import static com.velocitypowered.proxy.network.Connections.FLUSH_CONSOLIDATION_AMOUNT; import static com.velocitypowered.proxy.network.Connections.FRAME_DECODER; import static com.velocitypowered.proxy.network.Connections.FRAME_ENCODER; import static com.velocitypowered.proxy.network.Connections.LEGACY_PING_DECODER; @@ -23,7 +21,6 @@ import com.velocitypowered.proxy.protocol.netty.MinecraftVarintLengthEncoder; import io.netty.channel.Channel; import io.netty.channel.ChannelInitializer; import io.netty.handler.codec.haproxy.HAProxyMessageDecoder; -import io.netty.handler.flush.FlushConsolidationHandler; import io.netty.handler.timeout.ReadTimeoutHandler; import java.util.concurrent.TimeUnit; @@ -39,8 +36,6 @@ public class ServerChannelInitializer extends ChannelInitializer { @Override protected void initChannel(final Channel ch) { ch.pipeline() - .addLast(FLUSH_CONSOLIDATION, new FlushConsolidationHandler( - FLUSH_CONSOLIDATION_AMOUNT, true)) .addLast(READ_TIMEOUT, new ReadTimeoutHandler(this.server.getConfiguration().getReadTimeout(), TimeUnit.MILLISECONDS))