Mirror von
https://github.com/PaperMC/Paper.git
synchronisiert 2024-12-16 03:20:07 +01:00
89d51d5f29
Because this exploit has been widely known for years and has not been fixed by Mojang, we decided that it was worth allowing people to toggle it on/off due to how easy it is to make it configurable. It should be noted that this decision does not promise all future exploits will be configurable.
26 Zeilen
1.7 KiB
Diff
26 Zeilen
1.7 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Jake Potrebic <jake.m.potrebic@gmail.com>
|
|
Date: Sat, 23 Sep 2023 22:31:54 -0700
|
|
Subject: [PATCH] Fix team sidebar objectives not being cleared
|
|
|
|
Objectives displayed in team sidebars were not cleared when switching
|
|
scoreboards. If a player's scoreboard has a displayed objective for the
|
|
'gold' sidebar, and their scoreboard was switched to one where they
|
|
still had a 'gold' team, it would still be displayed
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/scoreboard/CraftScoreboardManager.java b/src/main/java/org/bukkit/craftbukkit/scoreboard/CraftScoreboardManager.java
|
|
index cad42a0f3c016bf65181e50d139ae4e2fb9158a5..b3e1adeb932da9b3bed16acd94e2f16da48a7c72 100644
|
|
--- a/src/main/java/org/bukkit/craftbukkit/scoreboard/CraftScoreboardManager.java
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/scoreboard/CraftScoreboardManager.java
|
|
@@ -87,8 +87,8 @@ public final class CraftScoreboardManager implements ScoreboardManager {
|
|
|
|
// Old objective tracking
|
|
HashSet<Objective> removed = new HashSet<>();
|
|
- for (int i = 0; i < 3; ++i) {
|
|
- Objective scoreboardobjective = oldboard.getDisplayObjective(net.minecraft.world.scores.DisplaySlot.BY_ID.apply(i));
|
|
+ for (net.minecraft.world.scores.DisplaySlot slot : net.minecraft.world.scores.DisplaySlot.values()) { // Paper - clear all display slots
|
|
+ Objective scoreboardobjective = oldboard.getDisplayObjective(slot); // Paper - clear all display slots
|
|
if (scoreboardobjective != null && !removed.contains(scoreboardobjective)) {
|
|
entityplayer.connection.send(new ClientboundSetObjectivePacket(scoreboardobjective, 1));
|
|
removed.add(scoreboardobjective);
|