From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Newwind Date: Mon, 26 Aug 2024 14:01:37 +0200 Subject: [PATCH] Check dead flag in isAlive() If a plugin sets the health of a living entity above 0 after it has already died, the entity will be "revived". It will behave the exact same as before, except with the internal "dead" flag set, resulting in 2 behavior changes, A: it's completely invulnerable to all damage B: it's unable to pickup items isValid() for these bugged entities will return true, isDead() will return false, despite the dead flag. This patch checks that the mob isn't dead before saying its alive. Also, even if the plugin is responsibly checking !isDead() before modifying health, on very rare circumstances I am currently unable to replicate, these "revived" entities can still appear diff --git a/src/main/java/net/minecraft/world/entity/LivingEntity.java b/src/main/java/net/minecraft/world/entity/LivingEntity.java index ad536c76010957650814b293fc8220ac525c13f1..ceaba7b82e9ff73a14fdef046e63b07c4d0fd5e9 100644 --- a/src/main/java/net/minecraft/world/entity/LivingEntity.java +++ b/src/main/java/net/minecraft/world/entity/LivingEntity.java @@ -2145,7 +2145,7 @@ public abstract class LivingEntity extends Entity implements Attackable { @Override public boolean isAlive() { - return !this.isRemoved() && this.getHealth() > 0.0F; + return !this.isRemoved() && this.getHealth() > 0.0F && !this.dead; // Paper - Check this.dead } public boolean isLookingAtMe(LivingEntity entity, double d0, boolean flag, boolean visualShape, Predicate predicate, DoubleSupplier... entityYChecks) {