--- a/net/minecraft/server/CommandDispatcher.java +++ b/net/minecraft/server/CommandDispatcher.java @@ -19,12 +19,21 @@ import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; +// CraftBukkit start +import com.google.common.base.Joiner; +import java.util.LinkedHashSet; +import org.bukkit.craftbukkit.command.VanillaCommandWrapper; +import org.bukkit.event.player.PlayerCommandSendEvent; +import org.bukkit.event.server.ServerCommandEvent; +// CraftBukkit end + public class CommandDispatcher { private static final Logger LOGGER = LogManager.getLogger(); private final com.mojang.brigadier.CommandDispatcher b = new com.mojang.brigadier.CommandDispatcher(); - public CommandDispatcher(boolean flag) { + // CraftBukkit start + public final CommandDispatcher init(boolean flag) { CommandAdvancement.a(this.b); CommandExecute.a(this.b); CommandBossBar.a(this.b); @@ -100,14 +109,59 @@ } this.b.findAmbiguities((commandnode, commandnode1, commandnode2, collection) -> { - CommandDispatcher.LOGGER.warn("Ambiguity between arguments {} and {} with inputs: {}", this.b.getPath(commandnode1), this.b.getPath(commandnode2), collection); + // CommandDispatcher.LOGGER.warn("Ambiguity between arguments {} and {} with inputs: {}", this.b.getPath(commandnode1), this.b.getPath(commandnode2), collection); // CraftBukkit }); + return this; + } + + public CommandDispatcher() { + // CraftBukkit end this.b.setConsumer((commandcontext, flag1, i) -> { ((CommandListenerWrapper) commandcontext.getSource()).a(commandcontext, flag1, i); }); } + // CraftBukkit start + public int dispatchServerCommand(CommandListenerWrapper sender, String command) { + Joiner joiner = Joiner.on(" "); + if (command.startsWith("/")) { + command = command.substring(1); + } + + ServerCommandEvent event = new ServerCommandEvent(sender.getBukkitSender(), command); + org.bukkit.Bukkit.getPluginManager().callEvent(event); + if (event.isCancelled()) { + return 0; + } + command = event.getCommand(); + + String[] args = command.split(" "); + + String cmd = args[0]; + if (cmd.startsWith("minecraft:")) cmd = cmd.substring("minecraft:".length()); + if (cmd.startsWith("bukkit:")) cmd = cmd.substring("bukkit:".length()); + + // Block disallowed commands + if (cmd.equalsIgnoreCase("stop") || cmd.equalsIgnoreCase("kick") || cmd.equalsIgnoreCase("op") + || cmd.equalsIgnoreCase("deop") || cmd.equalsIgnoreCase("ban") || cmd.equalsIgnoreCase("ban-ip") + || cmd.equalsIgnoreCase("pardon") || cmd.equalsIgnoreCase("pardon-ip") || cmd.equalsIgnoreCase("reload")) { + return 0; + } + + // Handle vanilla commands; + if (sender.getWorld().getServer().getCommandBlockOverride(args[0])) { + args[0] = "minecraft:" + args[0]; + } + + return this.a(sender, joiner.join(args)); + } + public int a(CommandListenerWrapper commandlistenerwrapper, String s) { + return this.a(commandlistenerwrapper, s, s); + } + + public int a(CommandListenerWrapper commandlistenerwrapper, String s, String label) { + // CraftBukkit end StringReader stringreader = new StringReader(s); if (stringreader.canRead() && stringreader.peek() == '/') { @@ -134,7 +188,7 @@ if (commandsyntaxexception.getInput() != null && commandsyntaxexception.getCursor() >= 0) { int j = Math.min(commandsyntaxexception.getInput().length(), commandsyntaxexception.getCursor()); IChatBaseComponent ichatbasecomponent = (new ChatComponentText("")).a(EnumChatFormat.GRAY).a((chatmodifier) -> { - chatmodifier.setChatClickable(new ChatClickable(ChatClickable.EnumClickAction.SUGGEST_COMMAND, s)); + chatmodifier.setChatClickable(new ChatClickable(ChatClickable.EnumClickAction.SUGGEST_COMMAND, label)); // CraftBukkit }); if (j > 10) { @@ -184,11 +238,36 @@ } public void a(EntityPlayer entityplayer) { - Map, CommandNode> map = Maps.newHashMap(); + // CraftBukkit start + // Register Vanilla commands into builtRoot as before + Map, CommandNode> map = Maps.newIdentityHashMap(); // Use identity to prevent aliasing issues + RootCommandNode vanillaRoot = new RootCommandNode(); + + RootCommandNode vanilla = entityplayer.server.vanillaCommandDispatcher.a().getRoot(); + map.put(vanilla, vanillaRoot); + this.a(vanilla, vanillaRoot, entityplayer.getCommandListener(), (Map) map); + + // Now build the global commands in a second pass RootCommandNode rootcommandnode = new RootCommandNode(); map.put(this.b.getRoot(), rootcommandnode); this.a(this.b.getRoot(), rootcommandnode, entityplayer.getCommandListener(), (Map) map); + + Collection bukkit = new LinkedHashSet<>(); + for (CommandNode node : rootcommandnode.getChildren()) { + bukkit.add(node.getName()); + } + + PlayerCommandSendEvent event = new PlayerCommandSendEvent(entityplayer.getBukkitEntity(), new LinkedHashSet<>(bukkit)); + event.getPlayer().getServer().getPluginManager().callEvent(event); + + // Remove labels that were removed during the event + for (String orig : bukkit) { + if (!event.getCommands().contains(orig)) { + rootcommandnode.removeCommand(orig); + } + } + // CraftBukkit end entityplayer.playerConnection.sendPacket(new PacketPlayOutCommands(rootcommandnode)); } @@ -199,7 +278,7 @@ CommandNode commandnode2 = (CommandNode) iterator.next(); if (commandnode2.canUse(commandlistenerwrapper)) { - ArgumentBuilder argumentbuilder = commandnode2.createBuilder(); + ArgumentBuilder argumentbuilder = commandnode2.createBuilder(); // CraftBukkit - decompile error argumentbuilder.requires((icompletionprovider) -> { return true; @@ -218,11 +297,15 @@ } } - if (argumentbuilder.getRedirect() != null) { - argumentbuilder.redirect((CommandNode) map.get(argumentbuilder.getRedirect())); + // Craftbukkit start - fix redirected CommandNodes not being properly redirected if it is mapped after commandNode2 + CommandNode destination = commandnode2.getRedirect(); + if (destination != null) { + this.a(destination, (CommandNode) destination.createBuilder().build(), commandlistenerwrapper, map); + argumentbuilder.redirect((CommandNode) map.get(destination)); } + // Craftbukkit end - CommandNode commandnode3 = argumentbuilder.build(); + CommandNode commandnode3 = argumentbuilder.build(); // CraftBukkit - decompile error map.put(commandnode2, commandnode3); commandnode1.addChild(commandnode3);