From d6c3fe23e57068ae3e562a2b4a60f5542a4492fe Mon Sep 17 00:00:00 2001
From: Erik Broes <erikbroes@grum.nl>
Date: Thu, 24 Mar 2011 12:11:28 +0100
Subject: [PATCH] Minor logic change and small cleanups

---
 src/main/java/net/minecraft/server/ItemInWorldManager.java | 7 ++++---
 src/main/java/net/minecraft/server/NetServerHandler.java   | 4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/main/java/net/minecraft/server/ItemInWorldManager.java b/src/main/java/net/minecraft/server/ItemInWorldManager.java
index d21130f882..1c2dc575c4 100644
--- a/src/main/java/net/minecraft/server/ItemInWorldManager.java
+++ b/src/main/java/net/minecraft/server/ItemInWorldManager.java
@@ -195,16 +195,17 @@ public class ItemInWorldManager {
         boolean result = false;
         if (i1 > 0) {
             PlayerInteractEvent event = CraftEventFactory.callPlayerInteractEvent(entityhuman, Action.RIGHT_CLICK_BLOCK, i, j, k, l, itemstack);
-            if (event.useInteractedBlock() == Event.Result.DENY) {
+            if (event.useInteractedBlock() == Event.Result.DENY) {
                 // If we denied a door from opening, we need to send a correcting update to the client, as it already opened the door.
                 if (i1 == Block.WOODEN_DOOR.id) {
                     boolean bottom = (world.getData(i, j, k) & 8) == 0;
-                    ((EntityPlayer) entityhuman).a.b((Packet) (new Packet53BlockChange(i, j + (bottom ? 1 : -1), k, world)));
+                    ((EntityPlayer) entityhuman).a.b((Packet) (new Packet53BlockChange(i, j + (bottom ? 1 : -1), k, world)));
                 }
             } else {
                 result = Block.byId[i1].a(world, i, j, k, entityhuman);
             }
-            if (itemstack != null && event.useItemInHand() != Event.Result.DENY && (!result || event.useItemInHand() == Event.Result.ALLOW)) {
+            // If we have 'true' and no explicit deny *or* an explicit allow -- run the item part of the hook
+            if (itemstack != null && ((!result && event.useItemInHand() != Event.Result.DENY) || event.useItemInHand() == Event.Result.ALLOW)) {
                 result = itemstack.a(entityhuman, world, i, j, k, l);
             }
         }
diff --git a/src/main/java/net/minecraft/server/NetServerHandler.java b/src/main/java/net/minecraft/server/NetServerHandler.java
index 51d20f43a5..bc6bc0609a 100644
--- a/src/main/java/net/minecraft/server/NetServerHandler.java
+++ b/src/main/java/net/minecraft/server/NetServerHandler.java
@@ -374,7 +374,7 @@ public class NetServerHandler extends NetHandler implements ICommandListener {
     }
 
     public void a(Packet15Place packet15place) {
-        // CraftBukkit
+        // CraftBukkit start
         // This is a horrible hack needed because the client sends 2 packets on 'right mouse click'
         // aimed at a block. We shouldn't need to get the second packet if the data is handled
         // but we cannot know what the client will do, so we might still get it
@@ -409,7 +409,7 @@ public class NetServerHandler extends NetHandler implements ICommandListener {
                 return;
             }
 
-            // Don't call this event if using Buckets / signs
+            // CraftBukkit start
             PlayerInteractEvent event = CraftEventFactory.callPlayerInteractEvent(this.e, Action.RIGHT_CLICK_AIR, itemstack);
 
             if (!event.isCancelled()) {