2023-12-29 01:27:34 +01:00
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Cryptite <cryptite@gmail.com>
Date: Mon, 1 May 2023 16:22:43 -0500
Subject: [PATCH] Add PlayerShieldDisableEvent
Called whenever a players shield is disabled. This is mainly caused by
attacking players or monsters that carry axes.
The event, while similar to the PlayerItemCooldownEvent, offers other
behaviour and can hence not be implemented as a childtype of said event.
Specifically, cancelling the event prevents the game events from being
sent to the player.
Plugins listening to just the PlayerItemCooldownEvent may not want said
sideeffects, meaning the disable event cannot share a handlerlist with
the cooldown event
diff --git a/src/main/java/net/minecraft/world/entity/Mob.java b/src/main/java/net/minecraft/world/entity/Mob.java
2024-01-24 11:45:17 +01:00
index 433d8eccdd225651af8c88babfdb94d19ce546d8..026654c4d3a910f0dbfed5475f23137086618242 100644
2023-12-29 01:27:34 +01:00
--- a/src/main/java/net/minecraft/world/entity/Mob.java
+++ b/src/main/java/net/minecraft/world/entity/Mob.java
2024-01-23 15:43:48 +01:00
@@ -1690,7 +1690,11 @@ public abstract class Mob extends LivingEntity implements Targeting {
2023-12-29 01:27:34 +01:00
float f = 0.25F + (float) EnchantmentHelper.getBlockEfficiency(this) * 0.05F;
if (this.random.nextFloat() < f) {
- player.getCooldowns().addCooldown(Items.SHIELD, 100);
2024-01-13 16:35:59 +01:00
+ // Paper start - Add PlayerShieldDisableEvent
2023-12-29 01:27:34 +01:00
+ final io.papermc.paper.event.player.PlayerShieldDisableEvent shieldDisableEvent = new io.papermc.paper.event.player.PlayerShieldDisableEvent((org.bukkit.entity.Player) player.getBukkitEntity(), getBukkitEntity(), 100);
+ if (!shieldDisableEvent.callEvent()) return;
+ player.getCooldowns().addCooldown(Items.SHIELD, shieldDisableEvent.getCooldown());
2024-01-13 16:35:59 +01:00
+ // Paper end - Add PlayerShieldDisableEvent
2023-12-29 01:27:34 +01:00
this.level().broadcastEntityEvent(player, (byte) 30);
}
}
diff --git a/src/main/java/net/minecraft/world/entity/player/Player.java b/src/main/java/net/minecraft/world/entity/player/Player.java
2024-01-24 11:45:17 +01:00
index 2759fa8768cfa7a38af7266a8e58af5feab138fa..3ccfc9cbf1b9dd91f3cefaec8f2dbcfa6afba8a9 100644
2023-12-29 01:27:34 +01:00
--- a/src/main/java/net/minecraft/world/entity/player/Player.java
+++ b/src/main/java/net/minecraft/world/entity/player/Player.java
2024-01-24 11:45:17 +01:00
@@ -969,7 +969,7 @@ public abstract class Player extends LivingEntity {
2023-12-29 01:27:34 +01:00
protected void blockUsingShield(LivingEntity attacker) {
super.blockUsingShield(attacker);
if (attacker.canDisableShield()) {
- this.disableShield(true);
2024-01-13 16:35:59 +01:00
+ this.disableShield(true, attacker); // Paper - Add PlayerShieldDisableEvent
2023-12-29 01:27:34 +01:00
}
}
2024-01-24 11:45:17 +01:00
@@ -1452,7 +1452,14 @@ public abstract class Player extends LivingEntity {
2023-12-29 01:27:34 +01:00
this.attack(target);
}
2024-01-13 16:35:59 +01:00
+ @io.papermc.paper.annotation.DoNotUse // Paper - Add PlayerShieldDisableEvent
2023-12-29 01:27:34 +01:00
public void disableShield(boolean sprinting) {
2024-01-13 16:35:59 +01:00
+ // Paper start - Add PlayerShieldDisableEvent
2023-12-29 01:27:34 +01:00
+ disableShield(sprinting, null);
+ }
+
+ public void disableShield(boolean sprinting, @Nullable LivingEntity attacker) {
2024-01-13 16:35:59 +01:00
+ // Paper end - Add PlayerShieldDisableEvent
2023-12-29 01:27:34 +01:00
float f = 0.25F + (float) EnchantmentHelper.getBlockEfficiency(this) * 0.05F;
if (sprinting) {
2024-01-24 11:45:17 +01:00
@@ -1460,7 +1467,16 @@ public abstract class Player extends LivingEntity {
2023-12-29 01:27:34 +01:00
}
if (this.random.nextFloat() < f) {
- this.getCooldowns().addCooldown(Items.SHIELD, 100);
2024-01-13 16:35:59 +01:00
+ // Paper start - Add PlayerShieldDisableEvent
2023-12-29 01:27:34 +01:00
+ final org.bukkit.entity.Entity finalAttacker = attacker != null ? attacker.getBukkitEntity() : null;
+ if (finalAttacker != null) {
+ final io.papermc.paper.event.player.PlayerShieldDisableEvent shieldDisableEvent = new io.papermc.paper.event.player.PlayerShieldDisableEvent((org.bukkit.entity.Player) getBukkitEntity(), finalAttacker, 100);
+ if (!shieldDisableEvent.callEvent()) return;
+ this.getCooldowns().addCooldown(Items.SHIELD, shieldDisableEvent.getCooldown());
+ } else {
+ this.getCooldowns().addCooldown(Items.SHIELD, 100);
+ }
2024-01-13 16:35:59 +01:00
+ // Paper end - Add PlayerShieldDisableEvent
2023-12-29 01:27:34 +01:00
this.stopUsingItem();
this.level().broadcastEntityEvent(this, (byte) 30);
}