From 98069cff83c923d808b5fe8b54f0a2458a9a37e7 Mon Sep 17 00:00:00 2001
From: Camotoy <20743703+Camotoy@users.noreply.github.com>
Date: Wed, 21 Dec 2022 00:35:03 -0500
Subject: [PATCH 1/2] Fix certain sounds not correctly playing

Fixes #3463
---
 .../org/geysermc/geyser/util/SoundUtils.java  | 41 +++++++++++++------
 1 file changed, 29 insertions(+), 12 deletions(-)

diff --git a/core/src/main/java/org/geysermc/geyser/util/SoundUtils.java b/core/src/main/java/org/geysermc/geyser/util/SoundUtils.java
index b80a9afe7..ccfd658ce 100644
--- a/core/src/main/java/org/geysermc/geyser/util/SoundUtils.java
+++ b/core/src/main/java/org/geysermc/geyser/util/SoundUtils.java
@@ -25,6 +25,7 @@
 
 package org.geysermc.geyser.util;
 
+import com.github.steveice10.mc.protocol.data.game.level.sound.BuiltinSound;
 import com.github.steveice10.mc.protocol.data.game.level.sound.Sound;
 import com.nukkitx.math.vector.Vector3f;
 import com.nukkitx.protocol.bedrock.data.LevelEventType;
@@ -65,10 +66,7 @@ public final class SoundUtils {
      * @return a Bedrock sound
      */
     public static String translatePlaySound(String javaIdentifier) {
-        // Drop the Minecraft namespace if applicable
-        if (javaIdentifier.startsWith("minecraft:")) {
-            javaIdentifier = javaIdentifier.substring("minecraft:".length());
-        }
+        javaIdentifier = trim(javaIdentifier);
 
         SoundMapping soundMapping = Registries.SOUNDS.get(javaIdentifier);
         if (soundMapping == null || soundMapping.getPlaysound() == null) {
@@ -79,6 +77,23 @@ public final class SoundUtils {
         return soundMapping.getPlaysound();
     }
 
+    private static String trim(String identifier) {
+        // Drop the Minecraft namespace if applicable
+        if (identifier.startsWith("minecraft:")) {
+            return identifier.substring("minecraft:".length());
+        }
+        return identifier;
+    }
+
+    private static void playSound(GeyserSession session, String bedrockName, Vector3f position, float volume, float pitch) {
+        PlaySoundPacket playSoundPacket = new PlaySoundPacket();
+        playSoundPacket.setSound(bedrockName);
+        playSoundPacket.setPosition(position);
+        playSoundPacket.setVolume(volume);
+        playSoundPacket.setPitch(pitch);
+        session.sendUpstreamPacket(playSoundPacket);
+    }
+
     /**
      * Translates and plays a Java Builtin Sound for a Bedrock client
      *
@@ -88,22 +103,24 @@ public final class SoundUtils {
      * @param pitch the pitch
      */
     public static void playSound(GeyserSession session, Sound javaSound, Vector3f position, float volume, float pitch) {
-        String packetSound = javaSound.getName();
+        String packetSound;
+        if (!(javaSound instanceof BuiltinSound)) {
+            // Identifier needs trimmed probably.
+            packetSound = translatePlaySound(javaSound.getName());
+        } else {
+            packetSound = javaSound.getName();
+        }
 
         SoundMapping soundMapping = Registries.SOUNDS.get(packetSound);
         if (soundMapping == null) {
-            session.getGeyser().getLogger().debug("[Builtin] Sound mapping for " + packetSound + " not found");
+            session.getGeyser().getLogger().debug("[Builtin] Sound mapping for " + packetSound + " not found; assuming custom.");
+            playSound(session, packetSound, position, volume, pitch);
             return;
         }
 
         if (soundMapping.getPlaysound() != null) {
             // We always prefer the PlaySound mapping because we can control volume and pitch
-            PlaySoundPacket playSoundPacket = new PlaySoundPacket();
-            playSoundPacket.setSound(soundMapping.getPlaysound());
-            playSoundPacket.setPosition(position);
-            playSoundPacket.setVolume(volume);
-            playSoundPacket.setPitch(pitch);
-            session.sendUpstreamPacket(playSoundPacket);
+            playSound(session, soundMapping.getPlaysound(), position, volume, pitch);
             return;
         }
 

From fcd5fe1341ee1346d1576deac929e4483886c990 Mon Sep 17 00:00:00 2001
From: Camotoy <20743703+Camotoy@users.noreply.github.com>
Date: Wed, 21 Dec 2022 00:37:48 -0500
Subject: [PATCH 2/2] Wrong method call on previous commit

---
 core/src/main/java/org/geysermc/geyser/util/SoundUtils.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/src/main/java/org/geysermc/geyser/util/SoundUtils.java b/core/src/main/java/org/geysermc/geyser/util/SoundUtils.java
index ccfd658ce..fd694f53e 100644
--- a/core/src/main/java/org/geysermc/geyser/util/SoundUtils.java
+++ b/core/src/main/java/org/geysermc/geyser/util/SoundUtils.java
@@ -106,7 +106,7 @@ public final class SoundUtils {
         String packetSound;
         if (!(javaSound instanceof BuiltinSound)) {
             // Identifier needs trimmed probably.
-            packetSound = translatePlaySound(javaSound.getName());
+            packetSound = trim(javaSound.getName());
         } else {
             packetSound = javaSound.getName();
         }