From a780eeaae8d7a13c2c198a1880c14f0a704f5fb7 Mon Sep 17 00:00:00 2001
From: gecko10000 <60494179+gecko10000@users.noreply.github.com>
Date: Mon, 20 May 2024 10:52:41 -0700
Subject: [PATCH] Open advancement tab regardless of currently open tab (#4665)

---
 .../geyser/session/cache/AdvancementsCache.java        | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/core/src/main/java/org/geysermc/geyser/session/cache/AdvancementsCache.java b/core/src/main/java/org/geysermc/geyser/session/cache/AdvancementsCache.java
index da3c83ed4..6769b4330 100644
--- a/core/src/main/java/org/geysermc/geyser/session/cache/AdvancementsCache.java
+++ b/core/src/main/java/org/geysermc/geyser/session/cache/AdvancementsCache.java
@@ -91,15 +91,13 @@ public class AdvancementsCache {
         builder.validResultHandler((response) -> {
             String id = rootAdvancementIds.get(response.clickedButtonId());
             if (!id.equals("")) {
-                if (id.equals(currentAdvancementCategoryId)) {
-                    // The server thinks we are already on this tab
-                    buildAndShowListForm();
-                } else {
-                    // Send a packet indicating that we intend to open this particular advancement window
+                if (!id.equals(currentAdvancementCategoryId)) {
+                    // Send a packet indicating that we are opening this particular advancement window
                     ServerboundSeenAdvancementsPacket packet = new ServerboundSeenAdvancementsPacket(id);
                     session.sendDownstreamGamePacket(packet);
-                    // Wait for a response there
                 }
+                currentAdvancementCategoryId = id;
+                buildAndShowListForm();
             }
         });