Drop anything below 1.19.50

core/src/main/java/org/geysermc/geyser/network/GameProtocol.java

@@ -60,14 +60,6 @@ public final class GameProtocol {
     private static final PacketCodec DEFAULT_JAVA_CODEC = MinecraftCodec.CODEC;
 
     static {
-        SUPPORTED_BEDROCK_CODECS.add(Bedrock_v544.V544_CODEC);
-        SUPPORTED_BEDROCK_CODECS.add(Bedrock_v545.V545_CODEC.toBuilder()
-                .minecraftVersion("1.19.21/1.19.22")
-                .build());
-        SUPPORTED_BEDROCK_CODECS.add(Bedrock_v554.V554_CODEC.toBuilder()
-                .minecraftVersion("1.19.30/1.19.31")
-                .build());
-        SUPPORTED_BEDROCK_CODECS.add(Bedrock_v557.V557_CODEC);
         SUPPORTED_BEDROCK_CODECS.add(DEFAULT_BEDROCK_CODEC);
     }
 
@@ -85,16 +77,6 @@ public final class GameProtocol {
         return null;
     }
 
-    /* Bedrock convenience methods to gatekeep features and easily remove the check on version removal */
-
-    public static boolean supports1_19_30(GeyserSession session) {
-        return session.getUpstream().getProtocolVersion() >= Bedrock_v554.V554_CODEC.getProtocolVersion();
-    }
-
-    public static boolean supports1_19_50(GeyserSession session) {
-        return session.getUpstream().getProtocolVersion() >= Bedrock_v560.V560_CODEC.getProtocolVersion();
-    }
-
     /**
      * Gets the {@link PacketCodec} for Minecraft: Java Edition.
      *

core/src/main/java/org/geysermc/geyser/registry/populator/BlockRegistryPopulator.java

@@ -29,8 +29,6 @@ import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.node.ArrayNode;
 import com.google.common.collect.ImmutableMap;
 import com.nukkitx.nbt.*;
-import com.nukkitx.protocol.bedrock.v527.Bedrock_v527;
-import com.nukkitx.protocol.bedrock.v544.Bedrock_v544;
 import com.nukkitx.protocol.bedrock.v560.Bedrock_v560;
 import it.unimi.dsi.fastutil.ints.IntOpenHashSet;
 import it.unimi.dsi.fastutil.ints.IntSet;
@@ -74,7 +72,6 @@ public final class BlockRegistryPopulator {
     private static void registerBedrockBlocks() {
         BiFunction<String, NbtMapBuilder, String> emptyMapper = (bedrockIdentifier, statesBuilder) -> null;
         ImmutableMap<ObjectIntPair<String>, BiFunction<String, NbtMapBuilder, String>> blockMappers = ImmutableMap.<ObjectIntPair<String>, BiFunction<String, NbtMapBuilder, String>>builder()
-                .put(ObjectIntPair.of("1_19_20", Bedrock_v544.V544_CODEC.getProtocolVersion()), emptyMapper)
                 .put(ObjectIntPair.of("1_19_50", Bedrock_v560.V560_CODEC.getProtocolVersion()), emptyMapper)
                 .build();
 

core/src/main/java/org/geysermc/geyser/registry/populator/ItemRegistryPopulator.java

@@ -77,7 +77,6 @@ public class ItemRegistryPopulator {
 
     public static void populate() {
         Map<String, PaletteVersion> paletteVersions = new Object2ObjectOpenHashMap<>();
-        paletteVersions.put("1_19_20", new PaletteVersion(Bedrock_v544.V544_CODEC.getProtocolVersion(), Collections.emptyMap()));
         paletteVersions.put("1_19_50", new PaletteVersion(Bedrock_v560.V560_CODEC.getProtocolVersion(), Collections.emptyMap()));
 
         GeyserBootstrap bootstrap = GeyserImpl.getInstance().getBootstrap();

core/src/main/java/org/geysermc/geyser/translator/protocol/bedrock/BedrockRequestAbilityTranslator.java

@@ -43,11 +43,6 @@ public class BedrockRequestAbilityTranslator extends PacketTranslator<RequestAbi
 
     @Override
     public void translate(GeyserSession session, RequestAbilityPacket packet) {
-        // Gatekeep to 1.19.30 so older versions don't fire twice
-        if (!GameProtocol.supports1_19_30(session)) {
-            return;
-        }
-        
         if (packet.getAbility() == Ability.FLYING) {
             handle(session, packet.isBoolValue());
         }

core/src/main/java/org/geysermc/geyser/util/DimensionUtils.java

@@ -125,16 +125,14 @@ public class DimensionUtils {
 
         // Kind of silly but Bedrock 1.19.50 requires an acknowledgement after the
         // initial chunks are sent, prior to the client acknowledgement
-        if (GameProtocol.supports1_19_50(session)) {
+        // Note: send this before chunks are sent. Fixed https://github.com/GeyserMC/Geyser/issues/3421
-            // Note: send this before chunks are sent. Fixed https://github.com/GeyserMC/Geyser/issues/3421
+        PlayerActionPacket ackPacket = new PlayerActionPacket();
-            PlayerActionPacket ackPacket = new PlayerActionPacket();
+        ackPacket.setRuntimeEntityId(player.getGeyserId());
-            ackPacket.setRuntimeEntityId(player.getGeyserId());
+        ackPacket.setAction(PlayerActionType.DIMENSION_CHANGE_SUCCESS);
-            ackPacket.setAction(PlayerActionType.DIMENSION_CHANGE_SUCCESS);
+        ackPacket.setBlockPosition(Vector3i.ZERO);
-            ackPacket.setBlockPosition(Vector3i.ZERO);
+        ackPacket.setResultPosition(Vector3i.ZERO);
-            ackPacket.setResultPosition(Vector3i.ZERO);
+        ackPacket.setFace(0);
-            ackPacket.setFace(0);
+        session.sendUpstreamPacket(ackPacket);
-            session.sendUpstreamPacket(ackPacket);
-        }
 
         // TODO - fix this hack of a fix by sending the final dimension switching logic after sections have been sent.
         // The client wants sections sent to it before it can successfully respawn.