From 3448c2fa9b867b5df0e12448010b45195d37c2f1 Mon Sep 17 00:00:00 2001 From: Camotoy <20743703+Camotoy@users.noreply.github.com> Date: Mon, 23 Sep 2024 13:57:32 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: chris --- .../org/geysermc/geyser/configuration/AdvancedConfig.java | 2 +- .../java/org/geysermc/geyser/configuration/GeyserConfig.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/main/java/org/geysermc/geyser/configuration/AdvancedConfig.java b/core/src/main/java/org/geysermc/geyser/configuration/AdvancedConfig.java index e19b896e0..b60c8d986 100644 --- a/core/src/main/java/org/geysermc/geyser/configuration/AdvancedConfig.java +++ b/core/src/main/java/org/geysermc/geyser/configuration/AdvancedConfig.java @@ -68,7 +68,7 @@ public interface AdvancedConfig { @Comment(""" Geyser updates the Scoreboard after every Scoreboard packet, but when Geyser tries to handle - a lot of scoreboard packets per second can cause serious lag. + a lot of scoreboard packets per second, this can cause serious lag. This option allows you to specify after how many Scoreboard packets per seconds the Scoreboard updates will be limited to four updates per second.""") @DefaultNumeric(20) diff --git a/core/src/main/java/org/geysermc/geyser/configuration/GeyserConfig.java b/core/src/main/java/org/geysermc/geyser/configuration/GeyserConfig.java index 10e629581..0f42dea2e 100644 --- a/core/src/main/java/org/geysermc/geyser/configuration/GeyserConfig.java +++ b/core/src/main/java/org/geysermc/geyser/configuration/GeyserConfig.java @@ -53,7 +53,7 @@ public interface GeyserConfig { @Comment(""" For online mode authentication type only. - Stores a list of Bedrock players that should have their Java Edition account saved after login. + Stores a list of Bedrock player usernames that should have their Java Edition account saved after login. This saves a token that can be reused to authenticate the player later. This does not save emails or passwords, but you should still be cautious when adding to this list and giving others access to this Geyser instance's files. Removing a name from this list will delete its cached login information on the next Geyser startup. @@ -281,7 +281,7 @@ public interface GeyserConfig { @Override @Comment(""" What type of authentication Bedrock players will be checked against when logging into the Java server. - Can be floodgate (see https://wiki.geysermc.org/floodgate/), online, or offline.""") + Can be "floodgate" (see https://wiki.geysermc.org/floodgate/), "online", or "offline".""") @NonNull default AuthType authType() { return AuthType.ONLINE;