Fix firework stars being unobtainable from the creative menu

2024-11-04 23:30:17 +01:00 · 2021-09-22 19:27:49 -04:00 · 2021-09-22 19:27:49 -04:00 · 27a17ff183
Commit 27a17ff183
--- a/connector/src/main/java/org/geysermc/connector/registry/type/ItemMappings.java
+++ b/connector/src/main/java/org/geysermc/connector/registry/type/ItemMappings.java
@ -121,8 +121,9 @@ public class ItemMappings {
                    }
                } else {
                    if (!(mapping.getBedrockData() == data.getDamage() ||
-                            // Make exceptions for potions and tipped arrows, whose damage values can vary
-                            (mapping.getJavaIdentifier().endsWith("potion") || mapping.getJavaIdentifier().equals("minecraft:arrow")))) {
+                            // Make exceptions for potions, tipped arrows, and firework stars, whose damage values can vary
+                            (mapping.getJavaIdentifier().endsWith("potion") || mapping.getJavaIdentifier().equals("minecraft:arrow")
+                                    || mapping.getJavaIdentifier().equals("minecraft:firework_star")))) {
                        continue;
                    }
                }