3
0
Mirror von https://github.com/IntellectualSites/FastAsyncWorldEdit.git synchronisiert 2024-12-27 03:12:37 +01:00
FastAsyncWorldEdit/worldedit-bukkit/adapters
Jordan af83b2f9c9
fix: improve biome setting to avoid writing directly to chunk (#2757)
* fix: improve biome setting to avoid writing directly to chunk

 - Removes possibility of writing to the LevelChunkSection biomes PalettedContainer whilst it is being read for sending packets
 - I believe this occured mostly on clipboard operations where blocks are written before biomes, so chunks are being sent whilst writing biomes
 - This would explain why the error reported in the below issue (and others) is/was so rare
 - Of course I could be completely wrong about all of this, but given the line in LevelChunkSection#write that the error seems to consistently occur on is when writing biomes to the packet, and that the only place I can find in FAWE where we write to a "live" PalettedContainer is for biomes, I am reasonably confident that this is the cause
 - Should address #2729

* Remove self-refraction-check
2024-06-15 13:08:42 +02:00
..
adapter-1_19_4 fix: improve biome setting to avoid writing directly to chunk (#2757) 2024-06-15 13:08:42 +02:00
adapter-1_20 fix: improve biome setting to avoid writing directly to chunk (#2757) 2024-06-15 13:08:42 +02:00
adapter-1_20_2 fix: improve biome setting to avoid writing directly to chunk (#2757) 2024-06-15 13:08:42 +02:00
adapter-1_20_4 fix: improve biome setting to avoid writing directly to chunk (#2757) 2024-06-15 13:08:42 +02:00
adapter-1_20_5 fix: improve biome setting to avoid writing directly to chunk (#2757) 2024-06-15 13:08:42 +02:00