Upstream changes, use correct list of cached block changes

worldedit-bukkit/adapters/adapter-1_19_4/src/main/java/com/sk89q/worldedit/bukkit/adapter/ext/fawe/v1_19_R3/PaperweightAdapter.java

@@ -296,11 +296,11 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
 
     private static Block getBlockFromType(BlockType blockType) {
 
-        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.BLOCK).get(ResourceLocation.tryParse(blockType.getId()));
+        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.BLOCK).get(ResourceLocation.tryParse(blockType.id()));
     }
 
     private static Item getItemFromType(ItemType itemType) {
-        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(itemType.getId()));
+        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(itemType.id()));
     }
 
     @Override
@@ -468,7 +468,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
         CraftWorld craftWorld = ((CraftWorld) location.getWorld());
         ServerLevel worldServer = craftWorld.getHandle();
 
-        Entity createdEntity = createEntityFromId(state.getType().getId(), craftWorld.getHandle());
+        Entity createdEntity = createEntityFromId(state.getType().id(), craftWorld.getHandle());
 
         if (createdEntity != null) {
             CompoundBinaryTag nativeTag = state.getNbt();
@@ -575,7 +575,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
     @Override
     public org.bukkit.inventory.ItemStack adapt(BaseItemStack item) {
         ItemStack stack = new ItemStack(
-                DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(item.getType().getId())),
+                DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(item.getType().id())),
                 item.getAmount()
         );
         stack.setTag(((net.minecraft.nbt.CompoundTag) fromNative(item.getNbtData())));
@@ -859,7 +859,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
 
     public boolean generateFeature(ConfiguredFeatureType type, World world, EditSession session, BlockVector3 pt) {
         ServerLevel originalWorld = ((CraftWorld) world).getHandle();
-        ConfiguredFeature<?, ?> k = originalWorld.registryAccess().registryOrThrow(Registries.CONFIGURED_FEATURE).get(ResourceLocation.tryParse(type.getId()));
+        ConfiguredFeature<?, ?> k = originalWorld.registryAccess().registryOrThrow(Registries.CONFIGURED_FEATURE).get(ResourceLocation.tryParse(type.id()));
         ServerChunkCache chunkManager = originalWorld.getChunkSource();
         WorldGenLevel proxyLevel = PaperweightServerLevelDelegateProxy.newInstance(session, originalWorld, this);
         return k != null && k.place(proxyLevel, chunkManager.getGenerator(), random, new BlockPos(pt.x(), pt.y(), pt.z()));
@@ -867,7 +867,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
 
     public boolean generateStructure(StructureType type, World world, EditSession session, BlockVector3 pt) {
         ServerLevel originalWorld = ((CraftWorld) world).getHandle();
-        Structure k = originalWorld.registryAccess().registryOrThrow(Registries.STRUCTURE).get(ResourceLocation.tryParse(type.getId()));
+        Structure k = originalWorld.registryAccess().registryOrThrow(Registries.STRUCTURE).get(ResourceLocation.tryParse(type.id()));
         if (k == null) {
             return false;
         }

worldedit-bukkit/adapters/adapter-1_19_4/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_19_R3/FaweBlockStateListPopulator.java

@@ -5,9 +5,11 @@ import net.minecraft.core.Direction;
 import net.minecraft.core.Holder;
 import net.minecraft.server.MinecraftServer;
 import net.minecraft.server.level.ServerLevel;
+import net.minecraft.world.entity.Entity;
 import net.minecraft.world.flag.FeatureFlagSet;
 import net.minecraft.world.level.biome.Biome;
 import net.minecraft.world.level.biome.BiomeManager;
+import net.minecraft.world.level.block.Block;
 import net.minecraft.world.level.block.state.BlockState;
 import net.minecraft.world.level.border.WorldBorder;
 import net.minecraft.world.level.chunk.ChunkAccess;
@@ -103,4 +105,44 @@ public class FaweBlockStateListPopulator extends BlockStateListPopulator {
         return world.getWorldBorder();
     }
 
+    @Override
+    public boolean setBlock(final BlockPos pos, final BlockState state, final int flags, final int maxUpdateDepth) {
+        return world.setBlock(pos, state, flags, maxUpdateDepth);
+    }
+
+    @Override
+    public boolean removeBlock(final BlockPos pos, final boolean move) {
+        return world.removeBlock(pos, move);
+    }
+
+    @Override
+    public boolean destroyBlock(final BlockPos pos, final boolean drop, final Entity breakingEntity, final int maxUpdateDepth) {
+        return world.destroyBlock(pos, drop, breakingEntity, maxUpdateDepth);
+    }
+
+    @Override
+    public BlockState getBlockState(final BlockPos pos) {
+        BlockState state = world.getBlockState(pos);
+        try {
+            state = new BlockState(
+                    state.getBlock(),
+                    state.getValues(),
+                    PaperweightPlatformAdapter.getStatePropertiesCodec(state)
+            ) {
+                @Override
+                public boolean is(Block block) {
+                    return true;
+                }
+            };
+        } catch (IllegalAccessException e) {
+            e.printStackTrace();
+        }
+        return state;
+    }
+
+    @Override
+    public boolean setBlock(final BlockPos pos, final BlockState state, final int flags) {
+        return world.setBlock(pos, state, flags);
+    }
+
 }

worldedit-bukkit/adapters/adapter-1_19_4/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_19_R3/PaperweightFaweAdapter.java

@@ -494,7 +494,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
     public org.bukkit.inventory.ItemStack adapt(BaseItemStack baseItemStack) {
         ItemStack stack = new ItemStack(
                 DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM)
-                        .get(ResourceLocation.tryParse(baseItemStack.getType().getId())),
+                        .get(ResourceLocation.tryParse(baseItemStack.getType().id())),
                 baseItemStack.getAmount()
         );
         stack.setTag(((net.minecraft.nbt.CompoundTag) fromNative(baseItemStack.getNbtData())));
@@ -532,7 +532,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
         ConfiguredFeature<?, ?> configuredFeature = serverLevel
                 .registryAccess()
                 .registryOrThrow(Registries.CONFIGURED_FEATURE)
-                .get(ResourceLocation.tryParse(feature.getId()));
+                .get(ResourceLocation.tryParse(feature.id()));
         FaweBlockStateListPopulator populator = new FaweBlockStateListPopulator(serverLevel);
 
         Map<BlockPos, CraftBlockState> placed = TaskManager.taskManager().sync(() -> {
@@ -547,10 +547,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
                 )) {
                     return null;
                 }
-                return populator.getList().stream().collect(Collectors.toMap(
+                return new HashMap<>(populator.getLevel().capturedBlockStates);
-                        CraftBlockState::getPosition,
-                        craftBlockState -> craftBlockState
-                ));
             } finally {
                 serverLevel.captureBlockStates = false;
                 serverLevel.captureTreeGeneration = false;
@@ -568,7 +565,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
         Structure k = serverLevel
                 .registryAccess()
                 .registryOrThrow(Registries.STRUCTURE)
-                .get(ResourceLocation.tryParse(type.getId()));
+                .get(ResourceLocation.tryParse(type.id()));
         if (k == null) {
             return false;
         }
@@ -719,7 +716,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
                 .getServer()
                 .registryAccess()
                 .registryOrThrow(BIOME);
-        ResourceLocation resourceLocation = ResourceLocation.tryParse(biomeType.getId());
+        ResourceLocation resourceLocation = ResourceLocation.tryParse(biomeType.id());
         Biome biome = registry.get(resourceLocation);
         return registry.getId(biome);
     }

worldedit-bukkit/adapters/adapter-1_19_4/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_19_R3/PaperweightPlatformAdapter.java

@@ -11,6 +11,7 @@ import com.fastasyncworldedit.core.util.MathMan;
 import com.fastasyncworldedit.core.util.ReflectionUtils;
 import com.fastasyncworldedit.core.util.TaskManager;
 import com.mojang.datafixers.util.Either;
+import com.mojang.serialization.MapCodec;
 import com.sk89q.worldedit.bukkit.WorldEditPlugin;
 import com.sk89q.worldedit.bukkit.adapter.BukkitImplAdapter;
 import com.sk89q.worldedit.bukkit.adapter.Refraction;
@@ -46,6 +47,7 @@ import net.minecraft.world.level.biome.Biome;
 import net.minecraft.world.level.block.Block;
 import net.minecraft.world.level.block.Blocks;
 import net.minecraft.world.level.block.entity.BlockEntity;
+import net.minecraft.world.level.block.state.StateHolder;
 import net.minecraft.world.level.chunk.ChunkStatus;
 import net.minecraft.world.level.chunk.GlobalPalette;
 import net.minecraft.world.level.chunk.HashMapPalette;
@@ -59,7 +61,6 @@ import net.minecraft.world.level.entity.PersistentEntitySectionManager;
 import org.apache.logging.log4j.Logger;
 import org.bukkit.Bukkit;
 import org.bukkit.craftbukkit.v1_19_R3.CraftChunk;
-import sun.misc.Unsafe;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
@@ -99,6 +100,8 @@ public final class PaperweightPlatformAdapter extends NMSAdapter {
     private static final Field fieldTickingBlockCount;
     private static final Field fieldNonEmptyBlockCount;
 
+    private static final Field fieldPropertiesCodec;
+
     private static final MethodHandle methodGetVisibleChunk;
 
     private static final Field fieldThreadingDetector;
@@ -141,6 +144,9 @@ public final class PaperweightPlatformAdapter extends NMSAdapter {
             fieldNonEmptyBlockCount = LevelChunkSection.class.getDeclaredField(Refraction.pickName("nonEmptyBlockCount", "f"));
             fieldNonEmptyBlockCount.setAccessible(true);
 
+            fieldPropertiesCodec = StateHolder.class.getDeclaredField(Refraction.pickName("propertiesCodec", "f"));
+            fieldPropertiesCodec.setAccessible(true);
+
             Method getVisibleChunkIfPresent = ChunkMap.class.getDeclaredMethod(Refraction.pickName(
                     "getVisibleChunkIfPresent",
                     "b"
@@ -687,6 +693,12 @@ public final class PaperweightPlatformAdapter extends NMSAdapter {
         }
     }
 
+    public static MapCodec<net.minecraft.world.level.block.state.BlockState> getStatePropertiesCodec(
+            net.minecraft.world.level.block.state.BlockState state
+    ) throws IllegalAccessException {
+        return (MapCodec<net.minecraft.world.level.block.state.BlockState>) fieldPropertiesCodec.get(state);
+    }
+
     record FakeIdMapBlock(int size) implements IdMap<net.minecraft.world.level.block.state.BlockState> {
 
         @Override

worldedit-bukkit/adapters/adapter-1_20/src/main/java/com/sk89q/worldedit/bukkit/adapter/ext/fawe/v1_20_R1/PaperweightAdapter.java

@@ -297,11 +297,11 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
 
     private static Block getBlockFromType(BlockType blockType) {
 
-        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.BLOCK).get(ResourceLocation.tryParse(blockType.getId()));
+        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.BLOCK).get(ResourceLocation.tryParse(blockType.id()));
     }
 
     private static Item getItemFromType(ItemType itemType) {
-        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(itemType.getId()));
+        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(itemType.id()));
     }
 
     @Override
@@ -501,7 +501,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
         CraftWorld craftWorld = ((CraftWorld) location.getWorld());
         ServerLevel worldServer = craftWorld.getHandle();
 
-        Entity createdEntity = createEntityFromId(state.getType().getId(), craftWorld.getHandle());
+        Entity createdEntity = createEntityFromId(state.getType().id(), craftWorld.getHandle());
 
         if (createdEntity != null) {
             CompoundBinaryTag nativeTag = state.getNbt();
@@ -619,7 +619,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
     @Override
     public org.bukkit.inventory.ItemStack adapt(BaseItemStack item) {
         ItemStack stack = new ItemStack(
-                DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(item.getType().getId())),
+                DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(item.getType().id())),
                 item.getAmount()
         );
         stack.setTag(((net.minecraft.nbt.CompoundTag) fromNative(item.getNbtData())));
@@ -905,7 +905,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
     @Override
     public boolean generateFeature(ConfiguredFeatureType type, World world, EditSession session, BlockVector3 pt) {
         ServerLevel originalWorld = ((CraftWorld) world).getHandle();
-        ConfiguredFeature<?, ?> k = originalWorld.registryAccess().registryOrThrow(Registries.CONFIGURED_FEATURE).get(ResourceLocation.tryParse(type.getId()));
+        ConfiguredFeature<?, ?> k = originalWorld.registryAccess().registryOrThrow(Registries.CONFIGURED_FEATURE).get(ResourceLocation.tryParse(type.id()));
         ServerChunkCache chunkManager = originalWorld.getChunkSource();
         WorldGenLevel proxyLevel = PaperweightServerLevelDelegateProxy.newInstance(session, originalWorld, this);
         return k != null && k.place(proxyLevel, chunkManager.getGenerator(), random, new BlockPos(pt.x(), pt.y(), pt.z()));
@@ -913,7 +913,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
 
     public boolean generateStructure(StructureType type, World world, EditSession session, BlockVector3 pt) {
         ServerLevel originalWorld = ((CraftWorld) world).getHandle();
-        Structure k = originalWorld.registryAccess().registryOrThrow(Registries.STRUCTURE).get(ResourceLocation.tryParse(type.getId()));
+        Structure k = originalWorld.registryAccess().registryOrThrow(Registries.STRUCTURE).get(ResourceLocation.tryParse(type.id()));
         if (k == null) {
             return false;
         }

worldedit-bukkit/adapters/adapter-1_20/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R1/FaweBlockStateListPopulator.java

@@ -5,9 +5,11 @@ import net.minecraft.core.Direction;
 import net.minecraft.core.Holder;
 import net.minecraft.server.MinecraftServer;
 import net.minecraft.server.level.ServerLevel;
+import net.minecraft.world.entity.Entity;
 import net.minecraft.world.flag.FeatureFlagSet;
 import net.minecraft.world.level.biome.Biome;
 import net.minecraft.world.level.biome.BiomeManager;
+import net.minecraft.world.level.block.Block;
 import net.minecraft.world.level.block.state.BlockState;
 import net.minecraft.world.level.border.WorldBorder;
 import net.minecraft.world.level.chunk.ChunkAccess;
@@ -103,4 +105,44 @@ public class FaweBlockStateListPopulator extends BlockStateListPopulator {
         return world.getWorldBorder();
     }
 
+    @Override
+    public boolean setBlock(final BlockPos pos, final BlockState state, final int flags, final int maxUpdateDepth) {
+        return world.setBlock(pos, state, flags, maxUpdateDepth);
+    }
+
+    @Override
+    public boolean removeBlock(final BlockPos pos, final boolean move) {
+        return world.removeBlock(pos, move);
+    }
+
+    @Override
+    public boolean destroyBlock(final BlockPos pos, final boolean drop, final Entity breakingEntity, final int maxUpdateDepth) {
+        return world.destroyBlock(pos, drop, breakingEntity, maxUpdateDepth);
+    }
+
+    @Override
+    public BlockState getBlockState(final BlockPos pos) {
+        BlockState state = world.getBlockState(pos);
+        try {
+            state = new BlockState(
+                    state.getBlock(),
+                    state.getValues(),
+                    PaperweightPlatformAdapter.getStatePropertiesCodec(state)
+            ) {
+                @Override
+                public boolean is(Block block) {
+                    return true;
+                }
+            };
+        } catch (IllegalAccessException e) {
+            e.printStackTrace();
+        }
+        return state;
+    }
+
+    @Override
+    public boolean setBlock(final BlockPos pos, final BlockState state, final int flags) {
+        return world.setBlock(pos, state, flags);
+    }
+
 }

worldedit-bukkit/adapters/adapter-1_20/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R1/PaperweightFaweAdapter.java

@@ -494,7 +494,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
     public org.bukkit.inventory.ItemStack adapt(BaseItemStack baseItemStack) {
         ItemStack stack = new ItemStack(
                 DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM)
-                        .get(ResourceLocation.tryParse(baseItemStack.getType().getId())),
+                        .get(ResourceLocation.tryParse(baseItemStack.getType().id())),
                 baseItemStack.getAmount()
         );
         stack.setTag(((net.minecraft.nbt.CompoundTag) fromNative(baseItemStack.getNbtData())));
@@ -533,7 +533,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
         ConfiguredFeature<?, ?> configuredFeature = serverLevel
                 .registryAccess()
                 .registryOrThrow(Registries.CONFIGURED_FEATURE)
-                .get(ResourceLocation.tryParse(feature.getId()));
+                .get(ResourceLocation.tryParse(feature.id()));
         FaweBlockStateListPopulator populator = new FaweBlockStateListPopulator(serverLevel);
 
         Map<BlockPos, CraftBlockState> placed = TaskManager.taskManager().sync(() -> {
@@ -548,10 +548,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
                 )) {
                     return null;
                 }
-                return populator.getList().stream().collect(Collectors.toMap(
+                return new HashMap<>(populator.getLevel().capturedBlockStates);
-                        CraftBlockState::getPosition,
-                        craftBlockState -> craftBlockState
-                ));
             } finally {
                 serverLevel.captureBlockStates = false;
                 serverLevel.captureTreeGeneration = false;
@@ -569,7 +566,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
         Structure k = serverLevel
                 .registryAccess()
                 .registryOrThrow(Registries.STRUCTURE)
-                .get(ResourceLocation.tryParse(type.getId()));
+                .get(ResourceLocation.tryParse(type.id()));
         if (k == null) {
             return false;
         }
@@ -720,7 +717,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
                 .getServer()
                 .registryAccess()
                 .registryOrThrow(BIOME);
-        ResourceLocation resourceLocation = ResourceLocation.tryParse(biomeType.getId());
+        ResourceLocation resourceLocation = ResourceLocation.tryParse(biomeType.id());
         Biome biome = registry.get(resourceLocation);
         return registry.getId(biome);
     }

worldedit-bukkit/adapters/adapter-1_20/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R1/PaperweightPlatformAdapter.java

@@ -11,6 +11,7 @@ import com.fastasyncworldedit.core.util.MathMan;
 import com.fastasyncworldedit.core.util.ReflectionUtils;
 import com.fastasyncworldedit.core.util.TaskManager;
 import com.mojang.datafixers.util.Either;
+import com.mojang.serialization.MapCodec;
 import com.sk89q.worldedit.bukkit.WorldEditPlugin;
 import com.sk89q.worldedit.bukkit.adapter.BukkitImplAdapter;
 import com.sk89q.worldedit.bukkit.adapter.Refraction;
@@ -47,6 +48,7 @@ import net.minecraft.world.level.biome.Biome;
 import net.minecraft.world.level.block.Block;
 import net.minecraft.world.level.block.Blocks;
 import net.minecraft.world.level.block.entity.BlockEntity;
+import net.minecraft.world.level.block.state.StateHolder;
 import net.minecraft.world.level.chunk.ChunkAccess;
 import net.minecraft.world.level.chunk.ChunkStatus;
 import net.minecraft.world.level.chunk.GlobalPalette;
@@ -61,7 +63,6 @@ import net.minecraft.world.level.entity.PersistentEntitySectionManager;
 import org.apache.logging.log4j.Logger;
 import org.bukkit.Bukkit;
 import org.bukkit.craftbukkit.v1_20_R1.CraftChunk;
-import sun.misc.Unsafe;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
@@ -103,6 +104,8 @@ public final class PaperweightPlatformAdapter extends NMSAdapter {
     private static final Field fieldTickingBlockCount;
     private static final Field fieldNonEmptyBlockCount;
 
+    private static final Field fieldPropertiesCodec;
+
     private static final MethodHandle methodGetVisibleChunk;
 
     private static final Field fieldThreadingDetector;
@@ -151,6 +154,9 @@ public final class PaperweightPlatformAdapter extends NMSAdapter {
             fieldNonEmptyBlockCount = LevelChunkSection.class.getDeclaredField(Refraction.pickName("nonEmptyBlockCount", "e"));
             fieldNonEmptyBlockCount.setAccessible(true);
 
+            fieldPropertiesCodec = StateHolder.class.getDeclaredField(Refraction.pickName("propertiesCodec", "f"));
+            fieldPropertiesCodec.setAccessible(true);
+
             Method getVisibleChunkIfPresent = ChunkMap.class.getDeclaredMethod(Refraction.pickName(
                     "getVisibleChunkIfPresent",
                     "b"
@@ -701,6 +707,12 @@ public final class PaperweightPlatformAdapter extends NMSAdapter {
         }
     }
 
+    public static MapCodec<net.minecraft.world.level.block.state.BlockState> getStatePropertiesCodec(
+            net.minecraft.world.level.block.state.BlockState state
+    ) throws IllegalAccessException {
+        return (MapCodec<net.minecraft.world.level.block.state.BlockState>) fieldPropertiesCodec.get(state);
+    }
+
     record FakeIdMapBlock(int size) implements IdMap<net.minecraft.world.level.block.state.BlockState> {
 
         @Override

worldedit-bukkit/adapters/adapter-1_20_2/src/main/java/com/sk89q/worldedit/bukkit/adapter/ext/fawe/v1_20_R2/PaperweightAdapter.java

@@ -294,11 +294,11 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
 
     private static Block getBlockFromType(BlockType blockType) {
 
-        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.BLOCK).get(ResourceLocation.tryParse(blockType.getId()));
+        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.BLOCK).get(ResourceLocation.tryParse(blockType.id()));
     }
 
     private static Item getItemFromType(ItemType itemType) {
-        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(itemType.getId()));
+        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(itemType.id()));
     }
 
     @Override
@@ -468,7 +468,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
         CraftWorld craftWorld = ((CraftWorld) location.getWorld());
         ServerLevel worldServer = craftWorld.getHandle();
 
-        Entity createdEntity = createEntityFromId(state.getType().getId(), craftWorld.getHandle());
+        Entity createdEntity = createEntityFromId(state.getType().id(), craftWorld.getHandle());
 
         if (createdEntity != null) {
             CompoundBinaryTag nativeTag = state.getNbt();
@@ -575,7 +575,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
     @Override
     public org.bukkit.inventory.ItemStack adapt(BaseItemStack item) {
         ItemStack stack = new ItemStack(
-                DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(item.getType().getId())),
+                DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(item.getType().id())),
                 item.getAmount()
         );
         stack.setTag(((net.minecraft.nbt.CompoundTag) fromNative(item.getNbtData())));
@@ -860,7 +860,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
 
     public boolean generateFeature(ConfiguredFeatureType type, World world, EditSession session, BlockVector3 pt) {
         ServerLevel originalWorld = ((CraftWorld) world).getHandle();
-        ConfiguredFeature<?, ?> k = originalWorld.registryAccess().registryOrThrow(Registries.CONFIGURED_FEATURE).get(ResourceLocation.tryParse(type.getId()));
+        ConfiguredFeature<?, ?> k = originalWorld.registryAccess().registryOrThrow(Registries.CONFIGURED_FEATURE).get(ResourceLocation.tryParse(type.id()));
         ServerChunkCache chunkManager = originalWorld.getChunkSource();
         WorldGenLevel proxyLevel = PaperweightServerLevelDelegateProxy.newInstance(session, originalWorld, this);
         return k != null && k.place(proxyLevel, chunkManager.getGenerator(), random, new BlockPos(pt.x(), pt.y(), pt.z()));
@@ -868,7 +868,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
 
     public boolean generateStructure(StructureType type, World world, EditSession session, BlockVector3 pt) {
         ServerLevel originalWorld = ((CraftWorld) world).getHandle();
-        Structure k = originalWorld.registryAccess().registryOrThrow(Registries.STRUCTURE).get(ResourceLocation.tryParse(type.getId()));
+        Structure k = originalWorld.registryAccess().registryOrThrow(Registries.STRUCTURE).get(ResourceLocation.tryParse(type.id()));
         if (k == null) {
             return false;
         }

worldedit-bukkit/adapters/adapter-1_20_2/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R2/FaweBlockStateListPopulator.java

@@ -9,6 +9,7 @@ import net.minecraft.world.entity.Entity;
 import net.minecraft.world.flag.FeatureFlagSet;
 import net.minecraft.world.level.biome.Biome;
 import net.minecraft.world.level.biome.BiomeManager;
+import net.minecraft.world.level.block.Block;
 import net.minecraft.world.level.block.state.BlockState;
 import net.minecraft.world.level.border.WorldBorder;
 import net.minecraft.world.level.chunk.ChunkAccess;
@@ -121,7 +122,22 @@ public class FaweBlockStateListPopulator extends BlockStateListPopulator {
 
     @Override
     public BlockState getBlockState(final BlockPos pos) {
-        return world.getBlockState(pos);
+        BlockState state = world.getBlockState(pos);
+        try {
+            state = new BlockState(
+                    state.getBlock(),
+                    state.getValues(),
+                    PaperweightPlatformAdapter.getStatePropertiesCodec(state)
+            ) {
+                @Override
+                public boolean is(Block block) {
+                    return true;
+                }
+            };
+        } catch (IllegalAccessException e) {
+            e.printStackTrace();
+        }
+        return state;
     }
 
     @Override

worldedit-bukkit/adapters/adapter-1_20_2/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R2/PaperweightFaweAdapter.java

@@ -497,7 +497,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
     public org.bukkit.inventory.ItemStack adapt(BaseItemStack baseItemStack) {
         ItemStack stack = new ItemStack(
                 DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM)
-                        .get(ResourceLocation.tryParse(baseItemStack.getType().getId())),
+                        .get(ResourceLocation.tryParse(baseItemStack.getType().id())),
                 baseItemStack.getAmount()
         );
         stack.setTag(((net.minecraft.nbt.CompoundTag) fromNative(baseItemStack.getNbtData())));
@@ -536,7 +536,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
         ConfiguredFeature<?, ?> configuredFeature = serverLevel
                 .registryAccess()
                 .registryOrThrow(Registries.CONFIGURED_FEATURE)
-                .get(ResourceLocation.tryParse(feature.getId()));
+                .get(ResourceLocation.tryParse(feature.id()));
         FaweBlockStateListPopulator populator = new FaweBlockStateListPopulator(serverLevel);
 
         Map<BlockPos, CraftBlockState> placed = TaskManager.taskManager().sync(() -> {
@@ -551,10 +551,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
                 )) {
                     return null;
                 }
-                return populator.getList().stream().collect(Collectors.toMap(
+                return new HashMap<>(populator.getLevel().capturedBlockStates);
-                        CraftBlockState::getPosition,
-                        craftBlockState -> craftBlockState
-                ));
             } finally {
                 serverLevel.captureBlockStates = false;
                 serverLevel.captureTreeGeneration = false;
@@ -572,7 +569,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
         Structure k = serverLevel
                 .registryAccess()
                 .registryOrThrow(Registries.STRUCTURE)
-                .get(ResourceLocation.tryParse(type.getId()));
+                .get(ResourceLocation.tryParse(type.id()));
         if (k == null) {
             return false;
         }
@@ -725,7 +722,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
                 .getServer()
                 .registryAccess()
                 .registryOrThrow(BIOME);
-        ResourceLocation resourceLocation = ResourceLocation.tryParse(biomeType.getId());
+        ResourceLocation resourceLocation = ResourceLocation.tryParse(biomeType.id());
         Biome biome = registry.get(resourceLocation);
         return registry.getId(biome);
     }

worldedit-bukkit/adapters/adapter-1_20_2/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R2/PaperweightPlatformAdapter.java

@@ -11,6 +11,7 @@ import com.fastasyncworldedit.core.util.MathMan;
 import com.fastasyncworldedit.core.util.ReflectionUtils;
 import com.fastasyncworldedit.core.util.TaskManager;
 import com.mojang.datafixers.util.Either;
+import com.mojang.serialization.MapCodec;
 import com.sk89q.worldedit.bukkit.WorldEditPlugin;
 import com.sk89q.worldedit.bukkit.adapter.BukkitImplAdapter;
 import com.sk89q.worldedit.bukkit.adapter.Refraction;
@@ -44,6 +45,7 @@ import net.minecraft.world.level.biome.Biome;
 import net.minecraft.world.level.block.Block;
 import net.minecraft.world.level.block.Blocks;
 import net.minecraft.world.level.block.entity.BlockEntity;
+import net.minecraft.world.level.block.state.StateHolder;
 import net.minecraft.world.level.chunk.ChunkAccess;
 import net.minecraft.world.level.chunk.ChunkStatus;
 import net.minecraft.world.level.chunk.GlobalPalette;
@@ -58,7 +60,6 @@ import net.minecraft.world.level.entity.PersistentEntitySectionManager;
 import org.apache.logging.log4j.Logger;
 import org.bukkit.Bukkit;
 import org.bukkit.craftbukkit.v1_20_R2.CraftChunk;
-import sun.misc.Unsafe;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
@@ -100,6 +101,8 @@ public final class PaperweightPlatformAdapter extends NMSAdapter {
     private static final Field fieldTickingBlockCount;
     private static final Field fieldNonEmptyBlockCount;
 
+    private static final Field fieldPropertiesCodec;
+
     private static final MethodHandle methodGetVisibleChunk;
 
     private static final Field fieldThreadingDetector;
@@ -145,6 +148,9 @@ public final class PaperweightPlatformAdapter extends NMSAdapter {
             fieldNonEmptyBlockCount = LevelChunkSection.class.getDeclaredField(Refraction.pickName("nonEmptyBlockCount", "e"));
             fieldNonEmptyBlockCount.setAccessible(true);
 
+            fieldPropertiesCodec = StateHolder.class.getDeclaredField(Refraction.pickName("propertiesCodec", "f"));
+            fieldPropertiesCodec.setAccessible(true);
+
             Method getVisibleChunkIfPresent = ChunkMap.class.getDeclaredMethod(Refraction.pickName(
                     "getVisibleChunkIfPresent",
                     "b"
@@ -674,6 +680,12 @@ public final class PaperweightPlatformAdapter extends NMSAdapter {
         return List.of();
     }
 
+    public static MapCodec<net.minecraft.world.level.block.state.BlockState> getStatePropertiesCodec(
+            net.minecraft.world.level.block.state.BlockState state
+    ) throws IllegalAccessException {
+        return (MapCodec<net.minecraft.world.level.block.state.BlockState>) fieldPropertiesCodec.get(state);
+    }
+
     record FakeIdMapBlock(int size) implements IdMap<net.minecraft.world.level.block.state.BlockState> {
 
         @Override

worldedit-bukkit/adapters/adapter-1_20_4/src/main/java/com/sk89q/worldedit/bukkit/adapter/ext/fawe/v1_20_R3/PaperweightAdapter.java

@@ -148,6 +148,7 @@ import org.bukkit.generator.ChunkGenerator;
 import org.spigotmc.SpigotConfig;
 import org.spigotmc.WatchdogThread;
 
+import javax.annotation.Nullable;
 import java.lang.ref.WeakReference;
 import java.lang.reflect.Field;
 import java.lang.reflect.InvocationTargetException;
@@ -169,7 +170,6 @@ import java.util.concurrent.ExecutionException;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import java.util.stream.Collectors;
-import javax.annotation.Nullable;
 
 import static com.google.common.base.Preconditions.checkNotNull;
 import static com.google.common.base.Preconditions.checkState;
@@ -294,11 +294,11 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
 
     private static Block getBlockFromType(BlockType blockType) {
 
-        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.BLOCK).get(ResourceLocation.tryParse(blockType.getId()));
+        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.BLOCK).get(ResourceLocation.tryParse(blockType.id()));
     }
 
     private static Item getItemFromType(ItemType itemType) {
-        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(itemType.getId()));
+        return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(itemType.id()));
     }
 
     @Override
@@ -468,7 +468,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
         CraftWorld craftWorld = ((CraftWorld) location.getWorld());
         ServerLevel worldServer = craftWorld.getHandle();
 
-        Entity createdEntity = createEntityFromId(state.getType().getId(), craftWorld.getHandle());
+        Entity createdEntity = createEntityFromId(state.getType().id(), craftWorld.getHandle());
 
         if (createdEntity != null) {
             CompoundBinaryTag nativeTag = state.getNbt();
@@ -575,7 +575,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
     @Override
     public org.bukkit.inventory.ItemStack adapt(BaseItemStack item) {
         ItemStack stack = new ItemStack(
-                DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(item.getType().getId())),
+                DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(item.getType().id())),
                 item.getAmount()
         );
         stack.setTag(((net.minecraft.nbt.CompoundTag) fromNative(item.getNbtData())));
@@ -860,7 +860,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
 
     public boolean generateFeature(ConfiguredFeatureType type, World world, EditSession session, BlockVector3 pt) {
         ServerLevel originalWorld = ((CraftWorld) world).getHandle();
-        ConfiguredFeature<?, ?> k = originalWorld.registryAccess().registryOrThrow(Registries.CONFIGURED_FEATURE).get(ResourceLocation.tryParse(type.getId()));
+        ConfiguredFeature<?, ?> k = originalWorld.registryAccess().registryOrThrow(Registries.CONFIGURED_FEATURE).get(ResourceLocation.tryParse(type.id()));
         ServerChunkCache chunkManager = originalWorld.getChunkSource();
         WorldGenLevel proxyLevel = PaperweightServerLevelDelegateProxy.newInstance(session, originalWorld, this);
         return k != null && k.place(proxyLevel, chunkManager.getGenerator(), random, new BlockPos(pt.x(), pt.y(), pt.z()));
@@ -868,7 +868,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
 
     public boolean generateStructure(StructureType type, World world, EditSession session, BlockVector3 pt) {
         ServerLevel originalWorld = ((CraftWorld) world).getHandle();
-        Structure k = originalWorld.registryAccess().registryOrThrow(Registries.STRUCTURE).get(ResourceLocation.tryParse(type.getId()));
+        Structure k = originalWorld.registryAccess().registryOrThrow(Registries.STRUCTURE).get(ResourceLocation.tryParse(type.id()));
         if (k == null) {
             return false;
         }

worldedit-bukkit/adapters/adapter-1_20_4/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R3/FaweBlockStateListPopulator.java

@@ -9,6 +9,7 @@ import net.minecraft.world.entity.Entity;
 import net.minecraft.world.flag.FeatureFlagSet;
 import net.minecraft.world.level.biome.Biome;
 import net.minecraft.world.level.biome.BiomeManager;
+import net.minecraft.world.level.block.Block;
 import net.minecraft.world.level.block.state.BlockState;
 import net.minecraft.world.level.border.WorldBorder;
 import net.minecraft.world.level.chunk.ChunkAccess;
@@ -121,7 +122,22 @@ public class FaweBlockStateListPopulator extends BlockStateListPopulator {
 
     @Override
     public BlockState getBlockState(final BlockPos pos) {
-        return world.getBlockState(pos);
+        BlockState state = world.getBlockState(pos);
+        try {
+            state = new BlockState(
+                    state.getBlock(),
+                    state.getValues(),
+                    PaperweightPlatformAdapter.getStatePropertiesCodec(state)
+            ) {
+                @Override
+                public boolean is(Block block) {
+                    return true;
+                }
+            };
+        } catch (IllegalAccessException e) {
+            e.printStackTrace();
+        }
+        return state;
     }
 
     @Override

worldedit-bukkit/adapters/adapter-1_20_4/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R3/PaperweightFaweAdapter.java

@@ -497,7 +497,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
     public org.bukkit.inventory.ItemStack adapt(BaseItemStack baseItemStack) {
         ItemStack stack = new ItemStack(
                 DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM)
-                        .get(ResourceLocation.tryParse(baseItemStack.getType().getId())),
+                        .get(ResourceLocation.tryParse(baseItemStack.getType().id())),
                 baseItemStack.getAmount()
         );
         stack.setTag(((net.minecraft.nbt.CompoundTag) fromNative(baseItemStack.getNbtData())));
@@ -536,7 +536,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
         ConfiguredFeature<?, ?> configuredFeature = serverLevel
                 .registryAccess()
                 .registryOrThrow(Registries.CONFIGURED_FEATURE)
-                .get(ResourceLocation.tryParse(feature.getId()));
+                .get(ResourceLocation.tryParse(feature.id()));
         FaweBlockStateListPopulator populator = new FaweBlockStateListPopulator(serverLevel);
 
         Map<BlockPos, CraftBlockState> placed = TaskManager.taskManager().sync(() -> {
@@ -549,19 +549,16 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
                         serverLevel.random,
                         new BlockPos(pt.x(), pt.y(), pt.z())
                 )) {
+
                     return null;
                 }
-                return populator.getList().stream().collect(Collectors.toMap(
+                return new HashMap<>(populator.getLevel().capturedBlockStates);
-                        CraftBlockState::getPosition,
-                        craftBlockState -> craftBlockState
-                ));
             } finally {
                 serverLevel.captureBlockStates = false;
                 serverLevel.captureTreeGeneration = false;
                 serverLevel.capturedBlockStates.clear();
             }
         });
-
         return placeFeatureIntoSession(editSession, populator, placed);
         //FAWE end
     }
@@ -572,7 +569,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
         Structure k = serverLevel
                 .registryAccess()
                 .registryOrThrow(Registries.STRUCTURE)
-                .get(ResourceLocation.tryParse(type.getId()));
+                .get(ResourceLocation.tryParse(type.id()));
         if (k == null) {
             return false;
         }
@@ -725,7 +722,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
                 .getServer()
                 .registryAccess()
                 .registryOrThrow(BIOME);
-        ResourceLocation resourceLocation = ResourceLocation.tryParse(biomeType.getId());
+        ResourceLocation resourceLocation = ResourceLocation.tryParse(biomeType.id());
         Biome biome = registry.get(resourceLocation);
         return registry.getId(biome);
     }

worldedit-bukkit/adapters/adapter-1_20_4/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R3/PaperweightPlatformAdapter.java

@@ -11,6 +11,7 @@ import com.fastasyncworldedit.core.util.MathMan;
 import com.fastasyncworldedit.core.util.ReflectionUtils;
 import com.fastasyncworldedit.core.util.TaskManager;
 import com.mojang.datafixers.util.Either;
+import com.mojang.serialization.MapCodec;
 import com.sk89q.worldedit.bukkit.WorldEditPlugin;
 import com.sk89q.worldedit.bukkit.adapter.BukkitImplAdapter;
 import com.sk89q.worldedit.bukkit.adapter.Refraction;
@@ -44,6 +45,7 @@ import net.minecraft.world.level.biome.Biome;
 import net.minecraft.world.level.block.Block;
 import net.minecraft.world.level.block.Blocks;
 import net.minecraft.world.level.block.entity.BlockEntity;
+import net.minecraft.world.level.block.state.StateHolder;
 import net.minecraft.world.level.chunk.ChunkAccess;
 import net.minecraft.world.level.chunk.ChunkStatus;
 import net.minecraft.world.level.chunk.GlobalPalette;
@@ -99,6 +101,8 @@ public final class PaperweightPlatformAdapter extends NMSAdapter {
     private static final Field fieldTickingBlockCount;
     private static final Field fieldNonEmptyBlockCount;
 
+    private static final Field fieldPropertiesCodec;
+
     private static final MethodHandle methodGetVisibleChunk;
 
     private static final Field fieldThreadingDetector;
@@ -144,6 +148,9 @@ public final class PaperweightPlatformAdapter extends NMSAdapter {
             fieldNonEmptyBlockCount = LevelChunkSection.class.getDeclaredField(Refraction.pickName("nonEmptyBlockCount", "e"));
             fieldNonEmptyBlockCount.setAccessible(true);
 
+            fieldPropertiesCodec = StateHolder.class.getDeclaredField(Refraction.pickName("propertiesCodec", "f"));
+            fieldPropertiesCodec.setAccessible(true);
+
             Method getVisibleChunkIfPresent = ChunkMap.class.getDeclaredMethod(Refraction.pickName(
                     "getVisibleChunkIfPresent",
                     "b"
@@ -673,6 +680,12 @@ public final class PaperweightPlatformAdapter extends NMSAdapter {
         return List.of();
     }
 
+    public static MapCodec<net.minecraft.world.level.block.state.BlockState> getStatePropertiesCodec(
+            net.minecraft.world.level.block.state.BlockState state
+    ) throws IllegalAccessException {
+        return (MapCodec<net.minecraft.world.level.block.state.BlockState>) fieldPropertiesCodec.get(state);
+    }
+
     record FakeIdMapBlock(int size) implements IdMap<net.minecraft.world.level.block.state.BlockState> {
 
         @Override

worldedit-bukkit/adapters/adapter-1_20_5/src/main/java/com/sk89q/worldedit/bukkit/adapter/ext.fawe/v1_20_R4/PaperweightAdapter.java

@@ -142,6 +142,7 @@ import org.bukkit.generator.ChunkGenerator;
 import org.spigotmc.SpigotConfig;
 import org.spigotmc.WatchdogThread;
 
+import javax.annotation.Nullable;
 import java.lang.ref.WeakReference;
 import java.lang.reflect.Field;
 import java.lang.reflect.InvocationTargetException;
@@ -163,7 +164,6 @@ import java.util.concurrent.ExecutionException;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import java.util.stream.Collectors;
-import javax.annotation.Nullable;
 
 import static com.google.common.base.Preconditions.checkNotNull;
 import static com.google.common.base.Preconditions.checkState;
@@ -291,12 +291,12 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
     private static Block getBlockFromType(BlockType blockType) {
 
         return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.BLOCK).get(ResourceLocation.tryParse(
-                blockType.getId()));
+                blockType.id()));
     }
 
     private static Item getItemFromType(ItemType itemType) {
         return DedicatedServer.getServer().registryAccess().registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(
-                itemType.getId()));
+                itemType.id()));
     }
 
     @Override
@@ -470,7 +470,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
         CraftWorld craftWorld = ((CraftWorld) location.getWorld());
         ServerLevel worldServer = craftWorld.getHandle();
 
-        Entity createdEntity = createEntityFromId(state.getType().getId(), craftWorld.getHandle());
+        Entity createdEntity = createEntityFromId(state.getType().id(), craftWorld.getHandle());
 
         if (createdEntity != null) {
             CompoundBinaryTag nativeTag = state.getNbt();
@@ -598,7 +598,7 @@ public final class PaperweightAdapter implements BukkitImplAdapter<net.minecraft
     public org.bukkit.inventory.ItemStack adapt(BaseItemStack item) {
         final RegistryAccess.Frozen registryAccess = DedicatedServer.getServer().registryAccess();
         ItemStack stack = new ItemStack(
-                registryAccess.registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(item.getType().getId())),
+                registryAccess.registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(item.getType().id())),
                 item.getAmount()
         );
         final CompoundTag nbt = (net.minecraft.nbt.CompoundTag) fromNative(item.getNbtData());

worldedit-bukkit/adapters/adapter-1_20_5/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R4/FaweBlockStateListPopulator.java

@@ -1,13 +1,18 @@
 package com.sk89q.worldedit.bukkit.adapter.impl.fawe.v1_20_R4;
 
+import it.unimi.dsi.fastutil.objects.Reference2ObjectArrayMap;
 import net.minecraft.core.BlockPos;
 import net.minecraft.core.Direction;
 import net.minecraft.core.Holder;
 import net.minecraft.server.MinecraftServer;
 import net.minecraft.server.level.ServerLevel;
+import net.minecraft.world.entity.Entity;
+import net.minecraft.world.flag.FeatureFlagSet;
 import net.minecraft.world.level.biome.Biome;
 import net.minecraft.world.level.biome.BiomeManager;
+import net.minecraft.world.level.block.Block;
 import net.minecraft.world.level.block.state.BlockState;
+import net.minecraft.world.level.block.state.properties.Property;
 import net.minecraft.world.level.border.WorldBorder;
 import net.minecraft.world.level.chunk.ChunkAccess;
 import net.minecraft.world.level.chunk.ChunkSource;
@@ -66,6 +71,11 @@ public class FaweBlockStateListPopulator extends BlockStateListPopulator {
         return world.getSeaLevel();
     }
 
+    @Override
+    public FeatureFlagSet enabledFeatures() {
+        return world.enabledFeatures();
+    }
+
     @Override
     public float getShade(final Direction direction, final boolean shaded) {
         return world.getShade(direction, shaded);
@@ -97,4 +107,44 @@ public class FaweBlockStateListPopulator extends BlockStateListPopulator {
         return world.getWorldBorder();
     }
 
+    @Override
+    public boolean setBlock(final BlockPos pos, final BlockState state, final int flags, final int maxUpdateDepth) {
+        return world.setBlock(pos, state, flags, maxUpdateDepth);
+    }
+
+    @Override
+    public boolean removeBlock(final BlockPos pos, final boolean move) {
+        return world.removeBlock(pos, move);
+    }
+
+    @Override
+    public boolean destroyBlock(final BlockPos pos, final boolean drop, final Entity breakingEntity, final int maxUpdateDepth) {
+        return world.destroyBlock(pos, drop, breakingEntity, maxUpdateDepth);
+    }
+
+    @Override
+    public BlockState getBlockState(final BlockPos pos) {
+        BlockState state = world.getBlockState(pos);
+        try {
+            state = new BlockState(
+                    state.getBlock(),
+                    (Reference2ObjectArrayMap<Property<?>, Comparable<?>>) state.getValues(),
+                    PaperweightPlatformAdapter.getStatePropertiesCodec(state)
+            ) {
+                @Override
+                public boolean is(Block block) {
+                    return true;
+                }
+            };
+        } catch (IllegalAccessException e) {
+            e.printStackTrace();
+        }
+        return state;
+    }
+
+    @Override
+    public boolean setBlock(final BlockPos pos, final BlockState state, final int flags) {
+        return world.setBlock(pos, state, flags);
+    }
+
 }

worldedit-bukkit/adapters/adapter-1_20_5/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R4/PaperweightFaweAdapter.java

@@ -13,8 +13,8 @@ import com.fastasyncworldedit.core.util.TaskManager;
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
-import com.sk89q.jnbt.CompoundTag;
 import com.mojang.serialization.Codec;
+import com.sk89q.jnbt.CompoundTag;
 import com.sk89q.jnbt.Tag;
 import com.sk89q.worldedit.EditSession;
 import com.sk89q.worldedit.blocks.BaseItemStack;
@@ -57,8 +57,8 @@ import com.sk89q.worldedit.world.registry.BlockMaterial;
 import io.papermc.lib.PaperLib;
 import net.minecraft.core.BlockPos;
 import net.minecraft.core.Registry;
-import net.minecraft.core.SectionPos;
 import net.minecraft.core.RegistryAccess;
+import net.minecraft.core.SectionPos;
 import net.minecraft.core.WritableRegistry;
 import net.minecraft.core.component.DataComponentPatch;
 import net.minecraft.core.registries.Registries;
@@ -505,7 +505,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
     public org.bukkit.inventory.ItemStack adapt(BaseItemStack baseItemStack) {
         final RegistryAccess.Frozen registryAccess = DedicatedServer.getServer().registryAccess();
         ItemStack stack = new ItemStack(
-                registryAccess.registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(baseItemStack.getType().getId())),
+                registryAccess.registryOrThrow(Registries.ITEM).get(ResourceLocation.tryParse(baseItemStack.getType().id())),
                 baseItemStack.getAmount()
         );
         final net.minecraft.nbt.CompoundTag nbt = (net.minecraft.nbt.CompoundTag) fromNative(baseItemStack.getNbtData());
@@ -550,7 +550,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
         ConfiguredFeature<?, ?> configuredFeature = serverLevel
                 .registryAccess()
                 .registryOrThrow(Registries.CONFIGURED_FEATURE)
-                .get(ResourceLocation.tryParse(feature.getId()));
+                .get(ResourceLocation.tryParse(feature.id()));
         FaweBlockStateListPopulator populator = new FaweBlockStateListPopulator(serverLevel);
 
         Map<BlockPos, CraftBlockState> placed = TaskManager.taskManager().sync(() -> {
@@ -565,10 +565,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
                 )) {
                     return null;
                 }
-                return populator.getList().stream().collect(Collectors.toMap(
+                return new HashMap<>(populator.getLevel().capturedBlockStates);
-                        CraftBlockState::getPosition,
-                        craftBlockState -> craftBlockState
-                ));
             } finally {
                 serverLevel.captureBlockStates = false;
                 serverLevel.captureTreeGeneration = false;
@@ -586,7 +583,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
         Structure k = serverLevel
                 .registryAccess()
                 .registryOrThrow(Registries.STRUCTURE)
-                .get(ResourceLocation.tryParse(type.getId()));
+                .get(ResourceLocation.tryParse(type.id()));
         if (k == null) {
             return false;
         }
@@ -746,7 +743,7 @@ public final class PaperweightFaweAdapter extends FaweAdapter<net.minecraft.nbt.
                 .getServer()
                 .registryAccess()
                 .registryOrThrow(BIOME);
-        ResourceLocation resourceLocation = ResourceLocation.tryParse(biomeType.getId());
+        ResourceLocation resourceLocation = ResourceLocation.tryParse(biomeType.id());
         Biome biome = registry.get(resourceLocation);
         return registry.getId(biome);
     }

worldedit-bukkit/adapters/adapter-1_20_5/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R4/PaperweightPlatformAdapter.java

@@ -10,7 +10,7 @@ import com.fastasyncworldedit.core.math.BitArrayUnstretched;
 import com.fastasyncworldedit.core.util.MathMan;
 import com.fastasyncworldedit.core.util.ReflectionUtils;
 import com.fastasyncworldedit.core.util.TaskManager;
-import com.mojang.datafixers.util.Either;
+import com.mojang.serialization.MapCodec;
 import com.sk89q.worldedit.bukkit.WorldEditPlugin;
 import com.sk89q.worldedit.bukkit.adapter.BukkitImplAdapter;
 import com.sk89q.worldedit.bukkit.adapter.Refraction;
@@ -44,6 +44,7 @@ import net.minecraft.world.level.biome.Biome;
 import net.minecraft.world.level.block.Block;
 import net.minecraft.world.level.block.Blocks;
 import net.minecraft.world.level.block.entity.BlockEntity;
+import net.minecraft.world.level.block.state.StateHolder;
 import net.minecraft.world.level.chunk.ChunkAccess;
 import net.minecraft.world.level.chunk.GlobalPalette;
 import net.minecraft.world.level.chunk.HashMapPalette;
@@ -76,7 +77,6 @@ import java.util.Iterator;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
-import java.util.Optional;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.Semaphore;
 import java.util.concurrent.TimeUnit;
@@ -99,6 +99,8 @@ public final class PaperweightPlatformAdapter extends NMSAdapter {
     private static final Field fieldTickingBlockCount;
     private static final Field fieldNonEmptyBlockCount;
 
+    private static final Field fieldPropertiesCodec;
+
     private static final MethodHandle methodGetVisibleChunk;
 
     private static final Field fieldThreadingDetector;
@@ -144,6 +146,9 @@ public final class PaperweightPlatformAdapter extends NMSAdapter {
             fieldNonEmptyBlockCount = LevelChunkSection.class.getDeclaredField(Refraction.pickName("nonEmptyBlockCount", "e"));
             fieldNonEmptyBlockCount.setAccessible(true);
 
+            fieldPropertiesCodec = StateHolder.class.getDeclaredField(Refraction.pickName("propertiesCodec", "f"));
+            fieldPropertiesCodec.setAccessible(true);
+
             Method getVisibleChunkIfPresent = ChunkMap.class.getDeclaredMethod(Refraction.pickName(
                     "getVisibleChunkIfPresent",
                     "b"
@@ -671,6 +676,12 @@ public final class PaperweightPlatformAdapter extends NMSAdapter {
         return List.of();
     }
 
+    public static MapCodec<net.minecraft.world.level.block.state.BlockState> getStatePropertiesCodec(
+            net.minecraft.world.level.block.state.BlockState state
+    ) throws IllegalAccessException {
+        return (MapCodec<net.minecraft.world.level.block.state.BlockState>) fieldPropertiesCodec.get(state);
+    }
+
     record FakeIdMapBlock(int size) implements IdMap<net.minecraft.world.level.block.state.BlockState> {
 
         @Override

worldedit-bukkit/src/main/java/com/fastasyncworldedit/bukkit/adapter/IBukkitAdapter.java

@@ -166,10 +166,10 @@ public interface IBukkitAdapter {
      */
     default Material adapt(ItemType itemType) {
         checkNotNull(itemType);
-        if (!itemType.getId().startsWith("minecraft:")) {
+        if (!itemType.id().startsWith("minecraft:")) {
             throw new IllegalArgumentException("Bukkit only supports Minecraft items");
         }
-        return Material.getMaterial(itemType.getId().substring(10).toUpperCase(Locale.ROOT));
+        return Material.getMaterial(itemType.id().substring(10).toUpperCase(Locale.ROOT));
     }
 
     /**
@@ -180,10 +180,10 @@ public interface IBukkitAdapter {
      */
     default Material adapt(BlockType blockType) {
         checkNotNull(blockType);
-        if (!blockType.getId().startsWith("minecraft:")) {
+        if (!blockType.id().startsWith("minecraft:")) {
             throw new IllegalArgumentException("Bukkit only supports Minecraft blocks");
         }
-        String id = blockType.getId().substring(10).toUpperCase(Locale.ROOT);
+        String id = blockType.id().substring(10).toUpperCase(Locale.ROOT);
         return Material.getMaterial(id);
     }
 
@@ -293,11 +293,11 @@ public interface IBukkitAdapter {
     }
 
     default Biome adapt(BiomeType biomeType) {
-        if (!biomeType.getId().startsWith("minecraft:")) {
+        if (!biomeType.id().startsWith("minecraft:")) {
             throw new IllegalArgumentException("Bukkit only supports vanilla biomes");
         }
         try {
-            return Biome.valueOf(biomeType.getId().substring(10).toUpperCase(Locale.ROOT));
+            return Biome.valueOf(biomeType.id().substring(10).toUpperCase(Locale.ROOT));
         } catch (IllegalArgumentException e) {
             return null;
         }

worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitBiomeRegistry.java

@@ -40,7 +40,7 @@ class BukkitBiomeRegistry implements BiomeRegistry {
     @Override
     public Component getRichName(BiomeType biomeType) {
         return TranslatableComponent.of(
-                TranslationManager.makeTranslationKey("biome", biomeType.getId())
+                TranslationManager.makeTranslationKey("biome", biomeType.id())
         );
     }
 

worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitPlayer.java

@@ -162,7 +162,7 @@ public class BukkitPlayer extends AbstractPlayerActor {
         final PlayerInventory inv = player.getInventory();
         ItemStack newItem = BukkitAdapter.adapt(itemStack);
         TaskManager.taskManager().sync(() -> {
-            if (itemStack.getType().getId().equalsIgnoreCase(WorldEdit.getInstance().getConfiguration().wandItem)) {
+            if (itemStack.getType().id().equalsIgnoreCase(WorldEdit.getInstance().getConfiguration().wandItem)) {
                 inv.remove(newItem);
             }
             final ItemStack item = player.getInventory().getItemInMainHand();
@@ -267,7 +267,7 @@ public class BukkitPlayer extends AbstractPlayerActor {
 
     @Override
     public void setGameMode(GameMode gameMode) {
-        player.setGameMode(org.bukkit.GameMode.valueOf(gameMode.getId().toUpperCase(Locale.ROOT)));
+        player.setGameMode(org.bukkit.GameMode.valueOf(gameMode.id().toUpperCase(Locale.ROOT)));
     }
 
     @Override

worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitServerInterface.java

@@ -230,7 +230,7 @@ public class BukkitServerInterface extends AbstractPlatform implements MultiUser
 
     //FAWE start
     @Override
-    public String getId() {
+    public String id() {
         return "intellectualsites:bukkit";
     }
     //FAWE end

worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitWorld.java

@@ -226,7 +226,7 @@ public class BukkitWorld extends AbstractWorld {
     //FAWE end
 
     @Override
-    public String getId() {
+    public String id() {
         return getWorld().getName().replace(" ", "_").toLowerCase(Locale.ROOT);
     }
 

worldedit-cli/src/main/java/com/sk89q/worldedit/cli/CLIBlockRegistry.java

@@ -68,7 +68,7 @@ public class CLIBlockRegistry extends BundledBlockRegistry {
     @Override
     public Map<String, ? extends Property<?>> getProperties(BlockType blockType) {
         Map<String, FileRegistries.BlockProperty> properties =
-                CLIWorldEdit.inst.getFileRegistries().getDataFile().blocks.get(blockType.getId()).properties;
+                CLIWorldEdit.inst.getFileRegistries().getDataFile().blocks.get(blockType.id()).properties;
         Maps.EntryTransformer<String, FileRegistries.BlockProperty, Property<?>> entryTransform =
                 (key, value) -> createProperty(value.type, key, value.values);
         return ImmutableMap.copyOf(Maps.transformEntries(properties, entryTransform));

worldedit-cli/src/main/java/com/sk89q/worldedit/cli/CLIPlatform.java

@@ -115,7 +115,7 @@ class CLIPlatform extends AbstractPlatform {
     @Override
     public World matchWorld(World world) {
         return this.worlds.stream()
-                .filter(w -> w.getId().equals(world.getId()))
+                .filter(w -> w.id().equals(world.id()))
                 .findAny()
                 .orElse(null);
     }

worldedit-cli/src/main/java/com/sk89q/worldedit/cli/schematic/ClipboardWorld.java

@@ -85,7 +85,7 @@ public class ClipboardWorld extends AbstractWorld implements Clipboard, CLIWorld
     //FAWE end
 
     @Override
-    public String getId() {
+    public String id() {
         return getName().replace(" ", "_").toLowerCase(Locale.ROOT);
     }
 

worldedit-core/src/main/java/com/fastasyncworldedit/core/extent/DisallowedBlocksExtent.java

@@ -101,7 +101,7 @@ public class DisallowedBlocksExtent extends AbstractDelegateExtent implements IB
     @SuppressWarnings("unchecked")
     private <B extends BlockStateHolder<B>> B checkBlock(B block) {
         if (blockedBlocks != null) {
-            if (blockedBlocks.contains(block.getBlockType().getId())) {
+            if (blockedBlocks.contains(block.getBlockType().id())) {
                 return (B) (block instanceof BlockState ? RESERVED : RESERVED.toBaseBlock()); // set to reserved/empty
             }
         }
@@ -140,7 +140,7 @@ public class DisallowedBlocksExtent extends AbstractDelegateExtent implements IB
                 }
                 BlockState state = BlockTypesCache.states[block];
                 if (blockedBlocks != null) {
-                    if (blockedBlocks.contains(state.getBlockType().getId())) {
+                    if (blockedBlocks.contains(state.getBlockType().id())) {
                         blocks[i] = BlockTypesCache.ReservedIDs.__RESERVED__;
                         continue;
                     }

worldedit-core/src/main/java/com/fastasyncworldedit/core/extent/HistoryExtent.java

@@ -110,7 +110,7 @@ public class HistoryExtent extends AbstractDelegateExtent {
     @Override
     public boolean setBiome(BlockVector3 position, BiomeType newBiome) {
         BiomeType oldBiome = this.getBiome(position);
-        if (!oldBiome.getId().equals(newBiome.getId())) {
+        if (!oldBiome.id().equals(newBiome.id())) {
             this.changeSet.addBiomeChange(position.x(), position.y(), position.z(), oldBiome, newBiome);
             return getExtent().setBiome(position, newBiome);
         } else {
@@ -121,7 +121,7 @@ public class HistoryExtent extends AbstractDelegateExtent {
     @Override
     public boolean setBiome(int x, int y, int z, BiomeType newBiome) {
         BiomeType oldBiome = this.getBiome(mutable.setComponents(x, y, z));
-        if (!oldBiome.getId().equals(newBiome.getId())) {
+        if (!oldBiome.id().equals(newBiome.id())) {
             this.changeSet.addBiomeChange(x, y, z, oldBiome, newBiome);
             return getExtent().setBiome(x, y, z, newBiome);
         } else {

worldedit-core/src/main/java/com/fastasyncworldedit/core/extent/clipboard/io/FastSchematicWriter.java

@@ -237,7 +237,7 @@ public class FastSchematicWriter implements ClipboardWriter {
                     if (!brokenEntities) {
                         loc = loc.setPosition(loc.add(min.toVector3()));
                     }
-                    values.put("Id", new StringTag(state.getType().getId()));
+                    values.put("Id", new StringTag(state.getType().id()));
                     values.put("Pos", writeVector(loc));
                     values.put("Rotation", writeRotation(entity.getLocation()));
 
@@ -297,7 +297,7 @@ public class FastSchematicWriter implements ClipboardWriter {
             for (int i = 0; i < paletteList.size(); i++) {
                 int ordinal = paletteList.get(i);
                 BiomeType state = BiomeTypes.get(ordinal);
-                out12.writeNamedTag(state.getId(), i);
+                out12.writeNamedTag(state.id(), i);
             }
         });
 

worldedit-core/src/main/java/com/fastasyncworldedit/core/extent/clipboard/io/schematic/MinecraftStructure.java

@@ -183,7 +183,7 @@ public class MinecraftStructure implements ClipboardReader, ClipboardWriter {
 
             indexes.put(combined, (Integer) palette.size());
             HashMap<String, Object> paletteEntry = new HashMap<>();
-            paletteEntry.put("Name", type.getId());
+            paletteEntry.put("Name", type.id());
             if (block.getInternalId() != type.getInternalId()) {
                 Map<String, Object> properties = null;
                 for (AbstractProperty property : (List<AbstractProperty<?>>) type.getProperties()) {
@@ -239,7 +239,7 @@ public class MinecraftStructure implements ClipboardReader, ClipboardWriter {
                 Map<String, Tag> nbtMap = nbt.getValue();
                 // Replace rotation data
                 nbtMap.put("Rotation", writeRotation(entity.getLocation()));
-                nbtMap.put("id", new StringTag(state.getType().getId()));
+                nbtMap.put("id", new StringTag(state.getType().id()));
                 Map<String, Object> entityMap = FaweCache.INSTANCE.asMap("pos", pos, "blockPos", blockPos, "nbt", nbt);
                 entities.add(entityMap);
             }

worldedit-core/src/main/java/com/fastasyncworldedit/core/extent/processor/lighting/NMSRelighter.java

@@ -346,7 +346,7 @@ public class NMSRelighter implements Relighter {
             }
             int lightLevel = iChunk.getEmittedLight(node.x() & 15, node.y(), node.z() & 15);
             BlockState state = this.queue.getBlock(node.x(), node.y(), node.z());
-            String id = state.getBlockType().getId().toLowerCase(Locale.ROOT);
+            String id = state.getBlockType().id().toLowerCase(Locale.ROOT);
             if (lightLevel <= 1) {
                 continue;
             }
@@ -396,7 +396,7 @@ public class NMSRelighter implements Relighter {
             if (!(checkStairEast(state) && isStairOrTrueTop(state, top) && isSlabOrTrueValue(state, top ? "top" : "bottom"))) {
                 break east;
             }
-            if (!state.getBlockType().getId().toLowerCase(Locale.ROOT).contains("stair")) {
+            if (!state.getBlockType().id().toLowerCase(Locale.ROOT).contains("stair")) {
                 this.computeSpreadBlockLight(x + 1, y, z, currentLight, queue, visited);
                 break east;
             }
@@ -449,7 +449,7 @@ public class NMSRelighter implements Relighter {
             if (!(checkStairWest(state) && isStairOrTrueTop(state, top) && isSlabOrTrueValue(state, top ? "top" : "bottom"))) {
                 break west;
             }
-            if (!state.getBlockType().getId().toLowerCase(Locale.ROOT).contains("stair")) {
+            if (!state.getBlockType().id().toLowerCase(Locale.ROOT).contains("stair")) {
                 this.computeSpreadBlockLight(x - 1, y, z, currentLight, queue, visited);
                 break west;
             }
@@ -502,7 +502,7 @@ public class NMSRelighter implements Relighter {
             if (!(checkStairSouth(state) && isStairOrTrueTop(state, top) && isSlabOrTrueValue(state, top ? "top" : "bottom"))) {
                 break south;
             }
-            if (!state.getBlockType().getId().toLowerCase(Locale.ROOT).contains("stair")) {
+            if (!state.getBlockType().id().toLowerCase(Locale.ROOT).contains("stair")) {
                 this.computeSpreadBlockLight(x, y, z + 1, currentLight, queue, visited);
                 break south;
             }
@@ -555,7 +555,7 @@ public class NMSRelighter implements Relighter {
             if (!(checkStairNorth(state) && isStairOrTrueTop(state, top) && isSlabOrTrueValue(state, top ? "top" : "bottom"))) {
                 break north;
             }
-            if (!state.getBlockType().getId().toLowerCase(Locale.ROOT).contains("stair")) {
+            if (!state.getBlockType().id().toLowerCase(Locale.ROOT).contains("stair")) {
                 this.computeSpreadBlockLight(x, y, z - 1, currentLight, queue, visited);
                 break north;
             }
@@ -707,7 +707,7 @@ public class NMSRelighter implements Relighter {
     }
 
     private boolean checkStairNorth(BlockState state) {
-        if (!state.getBlockType().getId().toLowerCase(Locale.ROOT).contains("stair")) {
+        if (!state.getBlockType().id().toLowerCase(Locale.ROOT).contains("stair")) {
             return true;
         }
         Direction direction = getStairDir(state);
@@ -725,7 +725,7 @@ public class NMSRelighter implements Relighter {
     }
 
     private boolean checkStairSouth(BlockState state) {
-        if (!state.getBlockType().getId().toLowerCase(Locale.ROOT).contains("stair")) {
+        if (!state.getBlockType().id().toLowerCase(Locale.ROOT).contains("stair")) {
             return true;
         }
         Direction direction = getStairDir(state);
@@ -743,7 +743,7 @@ public class NMSRelighter implements Relighter {
     }
 
     private boolean checkStairEast(BlockState state) {
-        if (!state.getBlockType().getId().toLowerCase(Locale.ROOT).contains("stair")) {
+        if (!state.getBlockType().id().toLowerCase(Locale.ROOT).contains("stair")) {
             return true;
         }
         Direction direction = getStairDir(state);
@@ -761,7 +761,7 @@ public class NMSRelighter implements Relighter {
     }
 
     private boolean checkStairWest(BlockState state) {
-        if (!state.getBlockType().getId().toLowerCase(Locale.ROOT).contains("stair")) {
+        if (!state.getBlockType().id().toLowerCase(Locale.ROOT).contains("stair")) {
             return true;
         }
         Direction direction = getStairDir(state);
@@ -787,11 +787,11 @@ public class NMSRelighter implements Relighter {
     }
 
     private boolean isStairOrTrueTop(BlockState state, boolean top) {
-        return !state.getBlockType().getId().contains("stair") || state.getState(stairHalf).equals("top") == top;
+        return !state.getBlockType().id().contains("stair") || state.getState(stairHalf).equals("top") == top;
     }
 
     private boolean isSlabOrTrueValue(BlockState state, String value) {
-        return !state.getBlockType().getId().contains("slab") || state.getState(slabHalf).equals(value);
+        return !state.getBlockType().id().contains("slab") || state.getState(slabHalf).equals(value);
     }
 
     private void computeRemoveBlockLight(

worldedit-core/src/main/java/com/fastasyncworldedit/core/function/generator/CavesGen.java

@@ -236,7 +236,7 @@ public class CavesGen extends GenBase {
                                 BlockState material = chunk.getBlock(bx + local_x, local_y, bz + local_z);
                                 BlockState materialAbove = chunk.getBlock(bx + local_x, local_y + 1, bz + local_z);
                                 BlockType blockType = material.getBlockType();
-                                switch (blockType.getId()) {
+                                switch (blockType.id()) {
                                     case "minecraft:mycelium", "minecraft:grass_block" -> grassFound = true;
                                 }
                                 if (this.isSuitableBlock(material, materialAbove)) {
@@ -277,7 +277,7 @@ public class CavesGen extends GenBase {
     }
 
     protected boolean isSuitableBlock(BlockStateHolder material, BlockStateHolder materialAbove) {
-        return switch (material.getBlockType().getId()) {
+        return switch (material.getBlockType().id()) {
             case "minecraft:air", "minecraft:cave_air", "minecraft:void_air", "minecraft:water", "minecraft:lava", "minecraft:bedrock" -> false;
             default -> true;
         };

worldedit-core/src/main/java/com/fastasyncworldedit/core/function/mask/ABlockMask.java

@@ -40,7 +40,7 @@ public abstract class ABlockMask extends AbstractExtentMask {
                 List<BlockState> all = type.getAllStates();
                 hasAll = all.stream().map(this::test).reduce(true, (a, b) -> a && b);
                 if (hasAll) {
-                    strings.add(type.getId());
+                    strings.add(type.id());
                 } else {
                     for (BlockState state : all) {
                         if (test(state)) {

worldedit-core/src/main/java/com/fastasyncworldedit/core/function/mask/BlockMaskBuilder.java

@@ -183,7 +183,7 @@ public class BlockMaskBuilder {
                     builders = new ArrayList<>();
                     Pattern pattern = Pattern.compile("(minecraft:)?" + regex);
                     for (BlockType type : BlockTypesCache.values) {
-                        if (pattern.matcher(type.getId()).find()) {
+                        if (pattern.matcher(type.id()).find()) {
                             blockTypeList.add(type);
                             builders.add(new FuzzyStateAllowingBuilder(type));
                             add(type);
@@ -284,7 +284,7 @@ public class BlockMaskBuilder {
                 } else {
                     boolean success = false;
                     for (BlockType myType : BlockTypesCache.values) {
-                        if (myType.getId().matches("(minecraft:)?" + input)) {
+                        if (myType.id().matches("(minecraft:)?" + input)) {
                             add(myType);
                             success = true;
                         }
@@ -571,7 +571,7 @@ public class BlockMaskBuilder {
                 throw new IllegalArgumentException(String.format(
                         "Property %s cannot be applied to block type %s",
                         property.getName(),
-                        type.getId()
+                        type.id()
                 ));
             }
             masked.computeIfAbsent(property, k -> new ArrayList<>()).add(index);

worldedit-core/src/main/java/com/fastasyncworldedit/core/function/pattern/TypeSwapPattern.java

@@ -79,7 +79,7 @@ public class TypeSwapPattern extends AbstractExtentPattern {
     }
 
     private BlockState getNewBlock(BlockState existing) {
-        String oldId = existing.getBlockType().getId();
+        String oldId = existing.getBlockType().id();
         String newId = oldId;
         if (inputPattern != null) {
             newId = inputPattern.matcher(oldId).replaceAll(outputString);

worldedit-core/src/main/java/com/fastasyncworldedit/core/util/MainUtil.java

@@ -444,7 +444,7 @@ public class MainUtil {
     @Nonnull
     public static CompoundTag setEntityInfo(@Nonnull CompoundTag tag, @Nonnull Entity entity) {
         Map<String, Tag> map = new HashMap<>(tag.getValue());
-        map.put("Id", new StringTag(entity.getState().getType().getId()));
+        map.put("Id", new StringTag(entity.getState().getType().id()));
         ListTag pos = (ListTag) map.get("Pos");
         if (pos != null) {
             Location loc = entity.getLocation();

worldedit-core/src/main/java/com/fastasyncworldedit/core/util/TextureUtil.java

@@ -929,10 +929,10 @@ public class TextureUtil implements TextureHolder {
                     }.getType();
 
                     for (BlockType blockType : BlockTypesCache.values) {
-                        if (!blockType.getMaterial().isFullCube() || blockType.getId().toLowerCase().contains("shulker")) {
+                        if (!blockType.getMaterial().isFullCube() || blockType.id().toLowerCase().contains("shulker")) {
                             continue;
                         }
-                        switch (blockType.getId().toLowerCase(Locale.ROOT)) {
+                        switch (blockType.id().toLowerCase(Locale.ROOT)) {
                             case "slime_block":
                             case "honey_block":
                             case "mob_spawner":
@@ -940,7 +940,7 @@ public class TextureUtil implements TextureHolder {
                                 continue;
                         }
                         int combined = blockType.getInternalId();
-                        String id = blockType.getId();
+                        String id = blockType.id();
                         String[] split = id.split(":", 2);
                         String name = split.length == 1 ? id : split[1];
                         String nameSpace = split.length == 1 ? "" : split[0];

worldedit-core/src/main/java/com/sk89q/worldedit/LocalConfiguration.java

@@ -196,7 +196,7 @@ public abstract class LocalConfiguration {
                 BlockTypes.BEDROCK
                 FAWE end*/
         );
-        return blockTypes.stream().filter(Objects::nonNull).map(BlockType::getId).toArray(String[]::new);
+        return blockTypes.stream().filter(Objects::nonNull).map(BlockType::id).toArray(String[]::new);
     }
 
     /**
@@ -277,7 +277,7 @@ public abstract class LocalConfiguration {
                 id = Integer.parseInt(splitter[0]);
                 data = Byte.parseByte(splitter[1]);
             }
-            item = LegacyMapper.getInstance().getItemFromLegacy(id, data).getId();
+            item = LegacyMapper.getInstance().getItemFromLegacy(id, data).id();
         } catch (Throwable ignored) {
         }
 

worldedit-core/src/main/java/com/sk89q/worldedit/LocalSession.java

@@ -1879,7 +1879,7 @@ public class LocalSession implements TextureHolder {
      * @return item id of wand item, or {@code null}
      */
     public String getWandItem() {
-        return wandItem.getId();
+        return wandItem.id();
     }
 
     /**
@@ -1888,7 +1888,7 @@ public class LocalSession implements TextureHolder {
      * @return item id of nav wand item, or {@code null}
      */
     public String getNavWandItem() {
-        return navWandItem.getId();
+        return navWandItem.id();
     }
 
     /**

worldedit-core/src/main/java/com/sk89q/worldedit/blocks/BaseItem.java

@@ -128,7 +128,7 @@ public class BaseItem implements NbtValued {
             }
         }
 
-        return getType().getId() + nbtString;
+        return getType().id() + nbtString;
     }
     //FAWE end
 }

worldedit-core/src/main/java/com/sk89q/worldedit/command/BiomeCommands.java

@@ -98,7 +98,7 @@ public class BiomeCommands {
             PaginationBox paginationBox = PaginationBox.fromComponents("Available Biomes", "/biomelist -p %page%",
                     BiomeType.REGISTRY.values().stream()
                             .map(biomeType -> TextComponent.builder()
-                                    .append(biomeType.getId())
+                                    .append(biomeType.id())
                                     .append(" (")
                                     .append(biomeRegistry.getRichName(biomeType))
                                     .append(")")
@@ -166,7 +166,7 @@ public class BiomeCommands {
 
         List<Component> components = biomes.stream().map(biome ->
                 biomeRegistry.getRichName(biome).hoverEvent(
-                        HoverEvent.showText(TextComponent.of(biome.getId()))
+                        HoverEvent.showText(TextComponent.of(biome.id()))
                 )
         ).collect(Collectors.toList());
         actor.print(Caption.of(messageKey, TextUtils.join(components, TextComponent.of(", "))));

worldedit-core/src/main/java/com/sk89q/worldedit/command/GeneralCommands.java

@@ -349,7 +349,7 @@ public class GeneralCommands {
         if (world == null) {
             actor.print(Caption.of("worldedit.world.remove"));
         } else {
-            actor.print(Caption.of("worldedit.world.set", TextComponent.of(world.getId())));
+            actor.print(Caption.of("worldedit.world.set", TextComponent.of(world.id())));
         }
     }
 
@@ -641,7 +641,7 @@ public class GeneralCommands {
                 if (itemsOnly && searchType.hasBlockType()) {
                     continue;
                 }
-                final String id = searchType.getId();
+                final String id = searchType.id();
                 if (id.contains(idMatch)) {
                     Component name = searchType.getRichName();
                     results.put(id, TextComponent.builder()

worldedit-core/src/main/java/com/sk89q/worldedit/command/SelectionCommands.java

@@ -832,7 +832,7 @@ public class SelectionCommands {
                 toolTip = TextComponent.of(state.getAsString());
                 blockName = blockName.append(TextComponent.of("*"));
             } else {
-                toolTip = TextComponent.of(blockType.getId());
+                toolTip = TextComponent.of(blockType.id());
             }
             blockName = blockName.hoverEvent(HoverEvent.of(HoverEvent.Action.SHOW_TEXT, toolTip));
             line.append(blockName);

worldedit-core/src/main/java/com/sk89q/worldedit/command/argument/WorldConverter.java

@@ -65,7 +65,7 @@ public class WorldConverter implements ArgumentConverter<World> {
     @Override
     public List<String> getSuggestions(String input, InjectedValueAccess context) {
         return getWorlds()
-                .map(World::getId)
+                .map(World::id)
                 .filter(world -> world.startsWith(input))
                 .collect(Collectors.toList());
     }
@@ -73,7 +73,7 @@ public class WorldConverter implements ArgumentConverter<World> {
     @Override
     public ConversionResult<World> convert(String s, InjectedValueAccess injectedValueAccess) {
         World result = getWorlds()
-                .filter(world -> world.getId().equals(s))
+                .filter(world -> world.id().equals(s))
                 .findAny().orElse(null);
         return result == null
                 ? FailedConversion.from(new IllegalArgumentException(

worldedit-core/src/main/java/com/sk89q/worldedit/command/tool/BlockDataCyler.java

@@ -66,7 +66,7 @@ public class BlockDataCyler implements DoubleActionBlockTool {
 
         if (!config.allowedDataCycleBlocks.isEmpty()
                 && !player.hasPermission("worldedit.override.data-cycler")
-                && !config.allowedDataCycleBlocks.contains(block.getBlockType().getId())) {
+                && !config.allowedDataCycleBlocks.contains(block.getBlockType().id())) {
             player.print(Caption.of("worldedit.tool.data-cycler.block-not-permitted"));
             return true;
         }

worldedit-core/src/main/java/com/sk89q/worldedit/extension/factory/parser/DefaultBlockParser.java

@@ -135,42 +135,42 @@ public class DefaultBlockParser extends InputParser<BaseBlock> {
     private String woolMapper(String string) {
         switch (string.toLowerCase(Locale.ROOT)) {
             case "white":
-                return BlockTypes.WHITE_WOOL.getId();
+                return BlockTypes.WHITE_WOOL.id();
             case "black":
-                return BlockTypes.BLACK_WOOL.getId();
+                return BlockTypes.BLACK_WOOL.id();
             case "blue":
-                return BlockTypes.BLUE_WOOL.getId();
+                return BlockTypes.BLUE_WOOL.id();
             case "brown":
-                return BlockTypes.BROWN_WOOL.getId();
+                return BlockTypes.BROWN_WOOL.id();
             case "cyan":
-                return BlockTypes.CYAN_WOOL.getId();
+                return BlockTypes.CYAN_WOOL.id();
             case "gray":
             case "grey":
-                return BlockTypes.GRAY_WOOL.getId();
+                return BlockTypes.GRAY_WOOL.id();
             case "green":
-                return BlockTypes.GREEN_WOOL.getId();
+                return BlockTypes.GREEN_WOOL.id();
             case "light_blue":
             case "lightblue":
-                return BlockTypes.LIGHT_BLUE_WOOL.getId();
+                return BlockTypes.LIGHT_BLUE_WOOL.id();
             case "light_gray":
             case "light_grey":
             case "lightgray":
             case "lightgrey":
-                return BlockTypes.LIGHT_GRAY_WOOL.getId();
+                return BlockTypes.LIGHT_GRAY_WOOL.id();
             case "lime":
-                return BlockTypes.LIME_WOOL.getId();
+                return BlockTypes.LIME_WOOL.id();
             case "magenta":
-                return BlockTypes.MAGENTA_WOOL.getId();
+                return BlockTypes.MAGENTA_WOOL.id();
             case "orange":
-                return BlockTypes.ORANGE_WOOL.getId();
+                return BlockTypes.ORANGE_WOOL.id();
             case "pink":
-                return BlockTypes.PINK_WOOL.getId();
+                return BlockTypes.PINK_WOOL.id();
             case "purple":
-                return BlockTypes.PURPLE_WOOL.getId();
+                return BlockTypes.PURPLE_WOOL.id();
             case "yellow":
-                return BlockTypes.YELLOW_WOOL.getId();
+                return BlockTypes.YELLOW_WOOL.id();
             case "red":
-                return BlockTypes.RED_WOOL.getId();
+                return BlockTypes.RED_WOOL.id();
             default:
                 return string;
         }
@@ -194,7 +194,7 @@ public class DefaultBlockParser extends InputParser<BaseBlock> {
                 if (input.indexOf('[') == -1 && input.indexOf(']') == -1) {
                     continue;
                 }
-                if (!type.getId().equalsIgnoreCase(input.substring(0, input.indexOf('[')))) {
+                if (!type.id().equalsIgnoreCase(input.substring(0, input.indexOf('[')))) {
                     continue;
                 }
                 String[] properties = input.substring(input.indexOf('[') + 1, input.indexOf(']')).split(",");
@@ -249,10 +249,10 @@ public class DefaultBlockParser extends InputParser<BaseBlock> {
                             throw new NoMatchException(Caption.of(
                                     "worldedit.error.parser.unknown-property",
                                     TextComponent.of(parts[0]),
-                                    TextComponent.of(type.getId())
+                                    TextComponent.of(type.id())
                             ));
                         } else {
-                            WorldEdit.logger.debug("Unknown property " + parts[0] + " for block " + type.getId());
+                            WorldEdit.logger.debug("Unknown property " + parts[0] + " for block " + type.id());
                         }
                         return Maps.newHashMap();
                     }
@@ -516,20 +516,20 @@ public class DefaultBlockParser extends InputParser<BaseBlock> {
             //FAWE start - per-limit disallowed blocks
             if (actor != null) {
                 if (!actor.hasPermission("worldedit.anyblock")
-                        && worldEdit.getConfiguration().disallowedBlocks.contains(blockType.getId().toLowerCase(Locale.ROOT))) {
+                        && worldEdit.getConfiguration().disallowedBlocks.contains(blockType.id().toLowerCase(Locale.ROOT))) {
                     throw new DisallowedUsageException(Caption.of(
                             "worldedit.error.disallowed-block",
-                            TextComponent.of(blockType.getId())
+                            TextComponent.of(blockType.id())
                     ));
                 }
                 FaweLimit limit = actor.getLimit();
                 if (!limit.isUnlimited()) {
                     // No need to account for blocked states/properties as it will simply return false in the equality check
                     // during contains.
-                    if (limit.DISALLOWED_BLOCKS.contains(blockType.getId().toLowerCase(Locale.ROOT))) {
+                    if (limit.DISALLOWED_BLOCKS.contains(blockType.id().toLowerCase(Locale.ROOT))) {
                         throw new DisallowedUsageException(Caption.of(
                                 "fawe.error.limit.disallowed-block",
-                                TextComponent.of(blockType.getId())
+                                TextComponent.of(blockType.id())
                         ));
                     }
                 }
@@ -559,14 +559,14 @@ public class DefaultBlockParser extends InputParser<BaseBlock> {
                 if (ent == null) {
                     throw new NoMatchException(Caption.of("worldedit.error.unknown-entity", TextComponent.of(mobName)));
                 }
-                mobName = ent.getId();
+                mobName = ent.id();
                 if (!worldEdit.getPlatformManager().queryCapability(Capability.USER_COMMANDS).isValidMobType(mobName)) {
                     throw new NoMatchException(Caption.of("worldedit.error.unknown-mob", TextComponent.of(mobName)));
                 }
                 return validate(context, new MobSpawnerBlock(state, mobName));
             } else {
                 //noinspection ConstantConditions
-                return validate(context, new MobSpawnerBlock(state, EntityTypes.PIG.getId()));
+                return validate(context, new MobSpawnerBlock(state, EntityTypes.PIG.id()));
             }
         } else if (blockType == BlockTypes.PLAYER_HEAD || blockType == BlockTypes.PLAYER_WALL_HEAD) {
             // allow setting type/player/rotation

worldedit-core/src/main/java/com/sk89q/worldedit/extension/factory/parser/pattern/BlockCategoryPatternParser.java

@@ -71,7 +71,7 @@ public class BlockCategoryPatternParser extends InputParser<Pattern> implements
 
         Set<BlockType> blocks = category.getAll();
         if (blocks.isEmpty()) {
-            throw new InputParseException(Caption.of("worldedit.error.empty-tag", TextComponent.of(category.getId())));
+            throw new InputParseException(Caption.of("worldedit.error.empty-tag", TextComponent.of(category.id())));
         }
 
         if (anyState) {

worldedit-core/src/main/java/com/sk89q/worldedit/extension/platform/Platform.java

@@ -23,7 +23,6 @@ import com.fastasyncworldedit.core.extent.processor.lighting.Relighter;
 import com.fastasyncworldedit.core.extent.processor.lighting.RelighterFactory;
 import com.fastasyncworldedit.core.queue.IBatchProcessor;
 import com.sk89q.worldedit.LocalConfiguration;
-import com.sk89q.worldedit.WorldEdit;
 import com.sk89q.worldedit.entity.Player;
 import com.sk89q.worldedit.internal.util.NonAbstractForCompatibility;
 import com.sk89q.worldedit.registry.Keyed;
@@ -233,7 +232,7 @@ public interface Platform extends Keyed {
      */
     @NonAbstractForCompatibility(delegateName = "getPlatformName", delegateParams = {})
     @Override
-    default String getId() {
+    default String id() {
         return "legacy:" + getPlatformName().toLowerCase(Locale.ROOT).replaceAll("[^a-z_.-]", "_");
     }
 

worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/Clipboard.java

@@ -407,7 +407,7 @@ public interface Clipboard extends Extent, Iterable<BlockVector3>, Closeable, Fl
         if (pasteEntities) {
             for (Entity entity : this.getEntities()) {
                 // skip players on pasting schematic
-                if (entity.getState() != null && entity.getState().getType().getId()
+                if (entity.getState() != null && entity.getState().getType().id()
                         .equals("minecraft:player")) {
                     continue;
                 }

worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/io/SpongeSchematicWriter.java

@@ -223,7 +223,7 @@ public class SpongeSchematicWriter implements ClipboardWriter {
                 BlockVector3 pt = BlockVector3.at(x0, min.y(), z0);
                 BiomeType biome = clipboard.getBiome(pt);
 
-                String biomeKey = biome.getId();
+                String biomeKey = biome.id();
                 int biomeId;
                 if (palette.containsKey(biomeKey)) {
                     biomeId = palette.get(biomeKey);
@@ -262,7 +262,7 @@ public class SpongeSchematicWriter implements ClipboardWriter {
                 values.putAll(rawData.getValue());
             }
             values.remove("id");
-            values.put("Id", new StringTag(state.getType().getId()));
+            values.put("Id", new StringTag(state.getType().id()));
             final Location location = e.getLocation();
             values.put("Pos", writeVector(location.toVector()));
             values.put("Rotation", writeRotation(location));

worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/io/legacycompat/FlowerPotCompatibilityHandler.java

@@ -84,7 +84,7 @@ public class FlowerPotCompatibilityHandler implements NBTCompatibilityHandler {
         } else {
             BlockState plantedWithData = LegacyMapper.getInstance().getBlockFromLegacy(newId, data);
             if (plantedWithData != null) {
-                plantedName = plantedWithData.getBlockType().getId().substring(10); // remove "minecraft:"
+                plantedName = plantedWithData.getBlockType().id().substring(10); // remove "minecraft:"
             }
         }
         if (plantedName != null) {

worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/io/legacycompat/Pre13HangingCompatibilityHandler.java

@@ -29,7 +29,7 @@ public class Pre13HangingCompatibilityHandler implements EntityNBTCompatibilityH
 
     @Override
     public boolean isAffectedEntity(EntityType type, CompoundTag tag) {
-        if (!type.getId().startsWith("minecraft:")) {
+        if (!type.id().startsWith("minecraft:")) {
             return false;
         }
         boolean hasLegacyDirection = tag.containsKey("Dir") || tag.containsKey("Direction");

worldedit-core/src/main/java/com/sk89q/worldedit/extent/transform/BlockTransformExtent.java

@@ -441,7 +441,7 @@ public class BlockTransformExtent extends ResettableExtent {
                         if (Settings.settings().ENABLED_COMPONENTS.DEBUG) {
                             LOGGER.warn(String.format(
                                     "Index outside direction array length found for block:{%s} property:{%s}",
-                                    state.getBlockType().getId(),
+                                    state.getBlockType().id(),
                                     property.getName()
                             ));
                         }

worldedit-core/src/main/java/com/sk89q/worldedit/function/block/SnowSimulator.java

@@ -116,7 +116,7 @@ public class SnowSimulator implements LayerFunction {
         if (!above.getBlockType().getMaterial().isAir() && (!stack || above.getBlockType() != BlockTypes.SNOW)) {
             return false;
             //FAWE start
-        } else if (!block.getBlockType().getId().toLowerCase(Locale.ROOT).contains("ice") && this.extent.getEmittedLight(
+        } else if (!block.getBlockType().id().toLowerCase(Locale.ROOT).contains("ice") && this.extent.getEmittedLight(
                 abovePosition) > 10) {
             return false;
         } else if (!block.getBlockType().getMaterial().isFullCube()) {
@@ -132,7 +132,7 @@ public class SnowSimulator implements LayerFunction {
                 return false;
             }
             //FAWE end
-        } else if (!block.getBlockType().getId().toLowerCase(Locale.ROOT).contains("ice") && block
+        } else if (!block.getBlockType().id().toLowerCase(Locale.ROOT).contains("ice") && block
                 .getBlockType()
                 .getMaterial()
                 .isTranslucent()) {

worldedit-core/src/main/java/com/sk89q/worldedit/internal/cui/ServerCUIHandler.java

@@ -165,7 +165,7 @@ public class ServerCUIHandler {
         structureTag.putString("mode", "SAVE");
         structureTag.putByte("ignoreEntities", (byte) 1);
         structureTag.putByte("showboundingbox", (byte) 1);
-        structureTag.putString("id", BlockTypes.STRUCTURE_BLOCK.getId());
+        structureTag.putString("id", BlockTypes.STRUCTURE_BLOCK.id());
 
         return BlockTypes.STRUCTURE_BLOCK.getDefaultState().toBaseBlock(structureTag.build());
         //FAWE end

worldedit-core/src/main/java/com/sk89q/worldedit/registry/Category.java

@@ -36,7 +36,7 @@ public abstract class Category<T extends Keyed> implements RegistryItem {
         this.id = id;
     }
 
-    public final String getId() {
+    public final String id() {
         return this.id;
     }
 
@@ -81,7 +81,7 @@ public abstract class Category<T extends Keyed> implements RegistryItem {
 
     @Override
     public String toString() {
-        return getId();
+        return id();
     }
 
 }

worldedit-core/src/main/java/com/sk89q/worldedit/registry/Keyed.java

@@ -29,6 +29,6 @@ public interface Keyed {
      *
      * @return an id
      */
-    String getId();
+    String id();
 
 }

worldedit-core/src/main/java/com/sk89q/worldedit/util/PropertiesConfiguration.java

@@ -114,7 +114,7 @@ public class PropertiesConfiguration extends LocalConfiguration {
         registerHelp = getBool("register-help", registerHelp);
         wandItem = getString("wand-item", wandItem).toLowerCase(Locale.ROOT);
         try {
-            wandItem = LegacyMapper.getInstance().getItemFromLegacy(Integer.parseInt(wandItem)).getId();
+            wandItem = LegacyMapper.getInstance().getItemFromLegacy(Integer.parseInt(wandItem)).id();
         } catch (Throwable ignored) {
         }
         superPickaxeDrop = getBool("super-pickaxe-drop-items", superPickaxeDrop);
@@ -124,7 +124,7 @@ public class PropertiesConfiguration extends LocalConfiguration {
         useInventoryCreativeOverride = getBool("use-inventory-creative-override", useInventoryCreativeOverride);
         navigationWand = getString("nav-wand-item", navigationWand).toLowerCase(Locale.ROOT);
         try {
-            navigationWand = LegacyMapper.getInstance().getItemFromLegacy(Integer.parseInt(navigationWand)).getId();
+            navigationWand = LegacyMapper.getInstance().getItemFromLegacy(Integer.parseInt(navigationWand)).id();
         } catch (Throwable ignored) {
         }
         navigationWandMaxDistance = getInt("nav-wand-distance", navigationWandMaxDistance);

worldedit-core/src/main/java/com/sk89q/worldedit/world/NullWorld.java

@@ -78,7 +78,7 @@ public class NullWorld extends AbstractWorld {
     //FAWE end
 
     @Override
-    public String getId() {
+    public String id() {
         return "null";
     }
 

worldedit-core/src/main/java/com/sk89q/worldedit/world/World.java

@@ -449,7 +449,7 @@ public interface World extends Extent, Keyed, IChunkCache<IChunkGet> {
     }
 
     @Override
-    default String getId() {
+    default String id() {
         return getName().replace(" ", "_").toLowerCase(Locale.ROOT);
     }
 

worldedit-core/src/main/java/com/sk89q/worldedit/world/biome/BiomeType.java

@@ -68,13 +68,13 @@ public class BiomeType implements RegistryItem, Keyed, BiomePattern {
      * @return The id
      */
     @Override
-    public String getId() {
+    public String id() {
         return this.id;
     }
 
     @Override
     public String toString() {
-        return getId();
+        return id();
     }
 
     @Override

worldedit-core/src/main/java/com/sk89q/worldedit/world/biome/BiomeTypes.java

@@ -291,7 +291,7 @@ public final class BiomeTypes {
     }
 
     public static BiomeType register(final BiomeType biome) {
-        return BiomeType.REGISTRY.register(biome.getId(), biome);
+        return BiomeType.REGISTRY.register(biome.id(), biome);
     }
 
     public static BiomeType getLegacy(int legacyId) {

worldedit-core/src/main/java/com/sk89q/worldedit/world/block/BlockState.java

@@ -154,7 +154,7 @@ public class BlockState implements BlockStateHolder<BlockState>, Pattern {
                 String input = key.toString();
                 throw new SuggestInputParseException(Caption.of("fawe.error.invalid-block-type", TextComponent.of(input)), () -> Stream.of(
                                 BlockTypesCache.values)
-                        .map(BlockType::getId)
+                        .map(BlockType::id)
                         .filter(id -> StringMan.blockStateMatches(input, id))
                         .sorted(StringMan.blockStateComparator(input))
                         .collect(Collectors.toList())

worldedit-core/src/main/java/com/sk89q/worldedit/world/block/BlockStateHolder.java

@@ -204,14 +204,14 @@ public interface BlockStateHolder<B extends BlockStateHolder<B>> extends TileEnt
 
     default String getAsString() {
         if (getStates().isEmpty()) {
-            return this.getBlockType().getId();
+            return this.getBlockType().id();
         } else {
             String properties = getStates().entrySet().stream()
                     .map(entry -> entry.getKey().getName()
                             + "="
                             + entry.getValue().toString().toLowerCase(Locale.ROOT))
                     .collect(Collectors.joining(","));
-            return this.getBlockType().getId() + "[" + properties + "]";
+            return this.getBlockType().id() + "[" + properties + "]";
         }
     }
 

worldedit-core/src/main/java/com/sk89q/worldedit/world/block/BlockType.java

@@ -124,7 +124,7 @@ public class BlockType implements Keyed, Pattern {
      * @return The id
      */
     @Override
-    public String getId() {
+    public String id() {
         return this.id;
     }
 
@@ -135,13 +135,13 @@ public class BlockType implements Keyed, Pattern {
 
     //FAWE start
     public String getNamespace() {
-        String id = getId();
+        String id = id();
         int i = id.indexOf(':');
         return i == -1 ? "minecraft" : id.substring(0, i);
     }
 
     public String getResource() {
-        String id = getId();
+        String id = id();
         return id.substring(id.indexOf(':') + 1);
     }
     //FAWE end
@@ -156,7 +156,7 @@ public class BlockType implements Keyed, Pattern {
     public String getName() {
         String name = this.name.getValue();
         if (name == null || name.isEmpty()) {
-            return getId();
+            return id();
         }
         return name;
     }
@@ -180,7 +180,7 @@ public class BlockType implements Keyed, Pattern {
             LOGGER.error(
                     "Attempted to load blockstate with id {} of type {} outside of state ordinals length. Using default state.",
                     propertyId,
-                    getId()
+                    id()
             );
             return settings.defaultState;
         }
@@ -189,7 +189,7 @@ public class BlockType implements Keyed, Pattern {
             LOGGER.error(
                     "Attempted to load blockstate with ordinal {} of type {} outside of states length. Using default state. Using default state.",
                     ordinal,
-                    getId()
+                    id()
             );
             return settings.defaultState;
         }
@@ -405,7 +405,7 @@ public class BlockType implements Keyed, Pattern {
 
     @Override
     public String toString() {
-        return getId();
+        return id();
     }
 
     //FAWE start

worldedit-core/src/main/java/com/sk89q/worldedit/world/block/BlockTypes.java

@@ -2235,8 +2235,8 @@ public final class BlockTypes {
 
         throw new SuggestInputParseException(Caption.of("fawe.error.invalid-block-type", TextComponent.of(input)), () -> Stream.of(
                         BlockTypesCache.values)
-                .filter(b -> StringMan.blockStateMatches(inputLower, b.getId()))
+                .filter(b -> StringMan.blockStateMatches(inputLower, b.id()))
-                .map(BlockType::getId)
+                .map(BlockType::id)
                 .sorted(StringMan.blockStateComparator(inputLower))
                 .collect(Collectors.toList())
         );

worldedit-core/src/main/java/com/sk89q/worldedit/world/chunk/AnvilChunk13.java

@@ -125,7 +125,7 @@ public class AnvilChunk13 implements Chunk {
                             } catch (IllegalArgumentException e) {
                                 throw new InvalidFormatException("Invalid block state for " + blockState
                                         .getBlockType()
-                                        .getId() + ", " + property.getName() + ": " + value);
+                                        .id() + ", " + property.getName() + ": " + value);
                             }
                         }
                     }

worldedit-core/src/main/java/com/sk89q/worldedit/world/chunk/AnvilChunk17.java

@@ -133,7 +133,7 @@ public class AnvilChunk17 implements Chunk {
                             } catch (IllegalArgumentException e) {
                                 throw new InvalidFormatException("Invalid block state for " + blockState
                                         .getBlockType()
-                                        .getId() + ", " + property.getName() + ": " + value);
+                                        .id() + ", " + property.getName() + ": " + value);
                             }
                         }
                     }

worldedit-core/src/main/java/com/sk89q/worldedit/world/chunk/AnvilChunk18.java

@@ -146,7 +146,7 @@ public class AnvilChunk18 implements Chunk {
                                 } catch (IllegalArgumentException e) {
                                     throw new InvalidFormatException("Invalid block state for " + blockState
                                             .getBlockType()
-                                            .getId() + ", " + property.getName() + ": " + value);
+                                            .id() + ", " + property.getName() + ": " + value);
                                 }
                             }
                         }

worldedit-core/src/main/java/com/sk89q/worldedit/world/entity/EntityType.java

@@ -40,7 +40,7 @@ public class EntityType implements RegistryItem, Keyed {
     }
 
     @Override
-    public String getId() {
+    public String id() {
         return this.id;
     }
 
@@ -64,12 +64,12 @@ public class EntityType implements RegistryItem, Keyed {
      * @return The name, or ID
      */
     public String getName() {
-        return getId();
+        return id();
     }
 
     @Override
     public String toString() {
-        return getId();
+        return id();
     }
 
     @Override

worldedit-core/src/main/java/com/sk89q/worldedit/world/fluid/FluidCategories.java

@@ -37,7 +37,7 @@ public final class FluidCategories {
     }
 
     public static FluidCategory register(final FluidCategory tag) {
-        return FluidCategory.REGISTRY.register(tag.getId(), tag);
+        return FluidCategory.REGISTRY.register(tag.id(), tag);
     }
 
     @Nullable

worldedit-core/src/main/java/com/sk89q/worldedit/world/fluid/FluidType.java

@@ -45,7 +45,7 @@ public class FluidType implements RegistryItem, Keyed {
      * @return The id
      */
     @Override
-    public String getId() {
+    public String id() {
         return this.id;
     }
 
@@ -67,7 +67,7 @@ public class FluidType implements RegistryItem, Keyed {
 
     @Override
     public String toString() {
-        return getId();
+        return id();
     }
 
     @Override

worldedit-core/src/main/java/com/sk89q/worldedit/world/fluid/FluidTypes.java

@@ -40,7 +40,7 @@ public final class FluidTypes {
     }
 
     public static FluidType register(final FluidType fluid) {
-        return FluidType.REGISTRY.register(fluid.getId(), fluid);
+        return FluidType.REGISTRY.register(fluid.id(), fluid);
     }
 
     @Nullable

worldedit-core/src/main/java/com/sk89q/worldedit/world/gamemode/GameMode.java

@@ -33,7 +33,7 @@ public class GameMode implements Keyed {
     }
 
     @Override
-    public String getId() {
+    public String id() {
         return this.id;
     }
 
@@ -43,12 +43,12 @@ public class GameMode implements Keyed {
      * @return The name, or ID
      */
     public String getName() {
-        return getId();
+        return id();
     }
 
     @Override
     public String toString() {
-        return getId();
+        return id();
     }
 
     @Override

worldedit-core/src/main/java/com/sk89q/worldedit/world/gamemode/GameModes.java

@@ -36,7 +36,7 @@ public final class GameModes {
     }
 
     public static GameMode register(final GameMode gameMode) {
-        return GameMode.REGISTRY.register(gameMode.getId(), gameMode);
+        return GameMode.REGISTRY.register(gameMode.id(), gameMode);
     }
 
     @Nullable

worldedit-core/src/main/java/com/sk89q/worldedit/world/generation/ConfiguredFeatureType.java

@@ -24,26 +24,17 @@ import com.sk89q.worldedit.math.BlockVector3;
 import com.sk89q.worldedit.registry.Keyed;
 import com.sk89q.worldedit.registry.NamespacedRegistry;
 
-public class ConfiguredFeatureType implements Keyed  {
+public record ConfiguredFeatureType(String id) implements Keyed {
+
     public static final NamespacedRegistry<ConfiguredFeatureType> REGISTRY = new NamespacedRegistry<>("configured feature type");
 
-    private final String id;
-
-    public ConfiguredFeatureType(String id) {
-        this.id = id;
-    }
-
-    @Override
-    public String getId() {
-        return this.id;
-    }
-
     @Override
     public String toString() {
         return this.id;
     }
 
     //FAWE start
+
     /**
      * Place this feature into an {@link EditSession}
      *

worldedit-core/src/main/java/com/sk89q/worldedit/world/generation/StructureType.java

@@ -24,26 +24,17 @@ import com.sk89q.worldedit.math.BlockVector3;
 import com.sk89q.worldedit.registry.Keyed;
 import com.sk89q.worldedit.registry.NamespacedRegistry;
 
-public class StructureType implements Keyed {
+public record StructureType(String id) implements Keyed {
+
     public static final NamespacedRegistry<StructureType> REGISTRY = new NamespacedRegistry<>("structure type");
 
-    private final String id;
-
-    public StructureType(String id) {
-        this.id = id;
-    }
-
-    @Override
-    public String getId() {
-        return this.id;
-    }
-
     @Override
     public String toString() {
         return this.id;
     }
 
     //FAWE start
+
     /**
      * Place this structure into an {@link EditSession}
      *

worldedit-core/src/main/java/com/sk89q/worldedit/world/item/ItemType.java

@@ -49,7 +49,7 @@ public class ItemType implements RegistryItem, Keyed {
                         .getRegistries().getItemRegistry().getName(this),
                 ""
         );
-        return name.isEmpty() ? getId() : name;
+        return name.isEmpty() ? id() : name;
     });
     @SuppressWarnings("this-escape")
     private transient final LazyReference<Component> richName = LazyReference.from(() ->
@@ -76,7 +76,7 @@ public class ItemType implements RegistryItem, Keyed {
     }
 
     @Override
-    public String getId() {
+    public String id() {
         return this.id;
     }
 
@@ -153,7 +153,7 @@ public class ItemType implements RegistryItem, Keyed {
 
     @Override
     public String toString() {
-        return getId();
+        return id();
     }
 
     @Override

worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/BundledBlockRegistry.java

@@ -41,7 +41,7 @@ public class BundledBlockRegistry implements BlockRegistry {
 
     @Override
     public Component getRichName(BlockType blockType) {
-        BundledBlockData.BlockEntry blockEntry = BundledBlockData.getInstance().findById(blockType.getId());
+        BundledBlockData.BlockEntry blockEntry = BundledBlockData.getInstance().findById(blockType.id());
         if (blockEntry != null) {
             // This is more likely to be "right", but not translated
             // Some vanilla MC blocks have overrides so we need this name here
@@ -50,7 +50,7 @@ public class BundledBlockRegistry implements BlockRegistry {
             return TextComponent.of(blockEntry.localizedName);
         }
         return Caption.of(
-                TranslationManager.makeTranslationKey("block", blockType.getId())
+                TranslationManager.makeTranslationKey("block", blockType.id())
         );
     }
 
@@ -60,14 +60,14 @@ public class BundledBlockRegistry implements BlockRegistry {
     // dumb_intellij.jpg - Ok??
     @SuppressWarnings("deprecation")
     public String getName(BlockType blockType) {
-        BundledBlockData.BlockEntry blockEntry = BundledBlockData.getInstance().findById(blockType.getId());
+        BundledBlockData.BlockEntry blockEntry = BundledBlockData.getInstance().findById(blockType.id());
         return blockEntry != null ? blockEntry.localizedName : null;
     }
 
     @Nullable
     @Override
     public BlockMaterial getMaterial(BlockType blockType) {
-        return new PassthroughBlockMaterial(BundledBlockData.getInstance().getMaterialById(blockType.getId()));
+        return new PassthroughBlockMaterial(BundledBlockData.getInstance().getMaterialById(blockType.id()));
     }
 
     @Nullable

worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/BundledItemRegistry.java

@@ -34,7 +34,7 @@ import javax.annotation.Nullable;
 public class BundledItemRegistry implements ItemRegistry {
 
     private BundledItemData.ItemEntry getEntryById(ItemType itemType) {
-        return BundledItemData.getInstance().findById(itemType.getId());
+        return BundledItemData.getInstance().findById(itemType.id());
     }
 
     @Override
@@ -48,7 +48,7 @@ public class BundledItemRegistry implements ItemRegistry {
             return TextComponent.of(itemEntry.localizedName);
         }
         return Caption.of(
-                TranslationManager.makeTranslationKey("item", itemType.getId())
+                TranslationManager.makeTranslationKey("item", itemType.id())
         );
     }
 
@@ -62,7 +62,7 @@ public class BundledItemRegistry implements ItemRegistry {
         if (itemEntry != null) {
             String localized = itemEntry.localizedName;
             if (localized.equals("Air")) {
-                String id = itemType.getId();
+                String id = itemType.id();
                 int c = id.indexOf(':');
                 return c < 0 ? id : id.substring(c + 1);
             }
@@ -74,7 +74,7 @@ public class BundledItemRegistry implements ItemRegistry {
     @Nullable
     @Override
     public ItemMaterial getMaterial(ItemType itemType) {
-        return new PassthroughItemMaterial(BundledItemData.getInstance().getMaterialById(itemType.getId()));
+        return new PassthroughItemMaterial(BundledItemData.getInstance().getMaterialById(itemType.id()));
     }
 
 }

worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/CategoryRegistry.java

@@ -38,7 +38,7 @@ public interface CategoryRegistry<T extends Keyed> {
     Set<T> getCategorisedByName(String category);
 
     default Set<T> getAll(final Category<T> category) {
-        return getCategorisedByName(category.getId());
+        return getCategorisedByName(category.id());
     }
 
 }

worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/NullBiomeRegistry.java

@@ -41,7 +41,7 @@ public class NullBiomeRegistry implements BiomeRegistry {
     @Override
     public Component getRichName(BiomeType biomeType) {
         return Caption.of(
-                TranslationManager.makeTranslationKey("biome", biomeType.getId())
+                TranslationManager.makeTranslationKey("biome", biomeType.id())
         );
     }
 

worldedit-core/src/main/java/com/sk89q/worldedit/world/weather/WeatherType.java

@@ -33,7 +33,7 @@ public class WeatherType implements Keyed {
     }
 
     @Override
-    public String getId() {
+    public String id() {
         return this.id;
     }
 
@@ -43,12 +43,12 @@ public class WeatherType implements Keyed {
      * @return The name, or ID
      */
     public String getName() {
-        return getId();
+        return id();
     }
 
     @Override
     public String toString() {
-        return getId();
+        return id();
     }
 
     @Override

worldedit-core/src/main/java/com/sk89q/worldedit/world/weather/WeatherTypes.java

@@ -35,7 +35,7 @@ public final class WeatherTypes {
     }
 
     public static WeatherType register(WeatherType weather) {
-        return WeatherType.REGISTRY.register(weather.getId(), weather);
+        return WeatherType.REGISTRY.register(weather.id(), weather);
     }
 
     @Nullable