From 378334bd752e5f3e61352dc50307fe3f4a8bb279 Mon Sep 17 00:00:00 2001 From: Hannes Greule Date: Tue, 3 Sep 2024 21:39:32 +0200 Subject: [PATCH] Avoid map lookup in `isMovementBlocker` calls (#2906) --- .../adapter/impl/fawe/v1_20_R2/PaperweightBlockMaterial.java | 3 ++- .../adapter/impl/fawe/v1_20_R3/PaperweightBlockMaterial.java | 3 ++- .../adapter/impl/fawe/v1_20_R4/PaperweightBlockMaterial.java | 3 ++- .../adapter/impl/fawe/v1_21_R1/PaperweightBlockMaterial.java | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/worldedit-bukkit/adapters/adapter-1_20_2/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R2/PaperweightBlockMaterial.java b/worldedit-bukkit/adapters/adapter-1_20_2/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R2/PaperweightBlockMaterial.java index 2e1dd8279..a50489b93 100644 --- a/worldedit-bukkit/adapters/adapter-1_20_2/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R2/PaperweightBlockMaterial.java +++ b/worldedit-bukkit/adapters/adapter-1_20_2/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R2/PaperweightBlockMaterial.java @@ -135,9 +135,10 @@ public class PaperweightBlockMaterial implements BlockMaterial { return block.isRandomlyTicking(blockState); } + @SuppressWarnings("deprecation") @Override public boolean isMovementBlocker() { - return craftMaterial.isSolid(); + return blockState.blocksMotion(); } @Override diff --git a/worldedit-bukkit/adapters/adapter-1_20_4/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R3/PaperweightBlockMaterial.java b/worldedit-bukkit/adapters/adapter-1_20_4/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R3/PaperweightBlockMaterial.java index 74b1c035c..857d09aa6 100644 --- a/worldedit-bukkit/adapters/adapter-1_20_4/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R3/PaperweightBlockMaterial.java +++ b/worldedit-bukkit/adapters/adapter-1_20_4/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R3/PaperweightBlockMaterial.java @@ -125,9 +125,10 @@ public class PaperweightBlockMaterial implements BlockMaterial { return block.isRandomlyTicking(blockState); } + @SuppressWarnings("deprecation") @Override public boolean isMovementBlocker() { - return craftMaterial.isSolid(); + return blockState.blocksMotion(); } @Override diff --git a/worldedit-bukkit/adapters/adapter-1_20_5/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R4/PaperweightBlockMaterial.java b/worldedit-bukkit/adapters/adapter-1_20_5/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R4/PaperweightBlockMaterial.java index 9c2292451..e80ecf3cb 100644 --- a/worldedit-bukkit/adapters/adapter-1_20_5/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R4/PaperweightBlockMaterial.java +++ b/worldedit-bukkit/adapters/adapter-1_20_5/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R4/PaperweightBlockMaterial.java @@ -126,9 +126,10 @@ public class PaperweightBlockMaterial implements BlockMaterial { return blockState.isRandomlyTicking(); } + @SuppressWarnings("deprecation") @Override public boolean isMovementBlocker() { - return craftMaterial.isSolid(); + return blockState.blocksMotion(); } @Override diff --git a/worldedit-bukkit/adapters/adapter-1_21/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_21_R1/PaperweightBlockMaterial.java b/worldedit-bukkit/adapters/adapter-1_21/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_21_R1/PaperweightBlockMaterial.java index 359527396..537072538 100644 --- a/worldedit-bukkit/adapters/adapter-1_21/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_21_R1/PaperweightBlockMaterial.java +++ b/worldedit-bukkit/adapters/adapter-1_21/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_21_R1/PaperweightBlockMaterial.java @@ -126,9 +126,10 @@ public class PaperweightBlockMaterial implements BlockMaterial { return blockState.isRandomlyTicking(); } + @SuppressWarnings("deprecation") @Override public boolean isMovementBlocker() { - return craftMaterial.isSolid(); + return blockState.blocksMotion(); } @Override